-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only import PostLocalSGD related modules when it's needed #10359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
four4fish
requested review from
awaelchli,
justusschock,
SeanNaren and
tchaton
as code owners
November 4, 2021 19:04
Codecov Report
@@ Coverage Diff @@
## master #10359 +/- ##
========================================
- Coverage 93% 89% -4%
========================================
Files 181 181
Lines 16471 16471
========================================
- Hits 15245 14611 -634
- Misses 1226 1860 +634 |
carmocca
approved these changes
Nov 5, 2021
ananthsub
approved these changes
Nov 5, 2021
awaelchli
approved these changes
Nov 5, 2021
justusschock
approved these changes
Nov 5, 2021
akihironitta
approved these changes
Nov 5, 2021
awaelchli
pushed a commit
that referenced
this pull request
Nov 8, 2021
* Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed
awaelchli
pushed a commit
that referenced
this pull request
Nov 9, 2021
* Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed
lexierule
pushed a commit
that referenced
this pull request
Nov 9, 2021
* Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed
Raalsky
pushed a commit
to neptune-ai/pytorch-lightning
that referenced
this pull request
Nov 23, 2021
…AI#10359) * Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed * Only import PostLocalSGD related modules when it's needed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
distributed
Generic distributed-related topic
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Partially Fixes #10348
Does your PR introduce any breaking changes? If yes, please list them.
DistributedOptimizer, PostLocalSGDOptimizer, ZeroRedundancyOptimizer and torch.distributed.algorithms modules only needed when
isinstance(self._ddp_comm_state, post_localSGD.PostLocalSGDState)
, move the import into _reinit_optimizers_with_post_localSGD() where these modules are used.Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃