-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deadlocks for distributed training for RichProgressBar #10428
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed offline, we need to validate that this works with users and try to get a test to ensure this works as expected in the future. Hard as current users are unable to share their reproduce!
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
What does this PR do?
Fixes #10362
Fixes were initially part of #9647 with @SeanNaren's efforts
Follow up PR would be to updating the refresh rate and add typing for RichProgress which is missing rn.
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃