Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlocks for distributed training for RichProgressBar #10428

Merged
merged 5 commits into from
Nov 9, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 9, 2021

What does this PR do?

Fixes #10362

Fixes were initially part of #9647 with @SeanNaren's efforts
Follow up PR would be to updating the refresh rate and add typing for RichProgress which is missing rn.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 modified the milestones: 1.6, 1.6.x Nov 9, 2021
@kaushikb11 kaushikb11 added bug Something isn't working priority: 0 High priority task progress bar: rich labels Nov 9, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review November 9, 2021 10:39
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 9, 2021
@awaelchli awaelchli mentioned this pull request Nov 9, 2021
11 tasks
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, we need to validate that this works with users and try to get a test to ensure this works as expected in the future. Hard as current users are unable to share their reproduce!

@mergify mergify bot added the has conflicts label Nov 9, 2021
@kaushikb11 kaushikb11 merged commit 5eeca87 into master Nov 9, 2021
@kaushikb11 kaushikb11 deleted the fix/rich_distrib branch November 9, 2021 13:00
awaelchli added a commit that referenced this pull request Nov 9, 2021
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
lexierule pushed a commit that referenced this pull request Nov 9, 2021
Co-authored-by: Kaushik Bokka <kaushikbokka@gmail.com>
@awaelchli awaelchli modified the milestones: 1.6.x, 1.5.x Nov 16, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working callback priority: 0 High priority task progress bar: rich ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RichProgressBar deadlocks distributed training
5 participants