Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scripting causing false positive deprecation warnings #10555

Merged
merged 3 commits into from
Nov 16, 2021
Merged

Fix scripting causing false positive deprecation warnings #10555

merged 3 commits into from
Nov 16, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 16, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Follow-up to #10470
Part of #9939

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @SeanNaren @awaelchli @edward-io

@carmocca carmocca added bug Something isn't working accelerator: ipu (removed) Intelligence Processing Unit logger: tensorboard labels Nov 16, 2021
@carmocca carmocca added this to the 1.5.x milestone Nov 16, 2021
@carmocca carmocca self-assigned this Nov 16, 2021
rohitgr7
rohitgr7 approved these changes Nov 16, 2021
View reviewed changes
pytorch_lightning/plugins/training_type/ipu.py Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
awaelchli
awaelchli approved these changes Nov 16, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

horrible

@carmocca @rohitgr7
Update pytorch_lightning/plugins/training_type/ipu.py
13cefa8 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@carmocca carmocca enabled auto-merge (squash) November 16, 2021 14:34
@carmocca carmocca merged commit edebd8a into master Nov 16, 2021
@carmocca carmocca deleted the bugfix/deprecation-model-size branch November 16, 2021 15:52
awaelchli pushed a commit that referenced this pull request Nov 16, 2021
@carmocca @rohitgr7 @awaelchli
Fix scripting causing false positive deprecation warnings (#10555)
308649b 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
lexierule pushed a commit that referenced this pull request Nov 16, 2021
@carmocca @rohitgr7 @lexierule
Fix scripting causing false positive deprecation warnings (#10555)
9e45024 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@carmocca @rohitgr7 @Raalsky
Fix scripting causing false positive deprecation warnings (Lightning-…
08d32d5 
…AI#10555)

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock justusschock approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
accelerator: ipu (removed) Intelligence Processing Unit bug Something isn't working logger: tensorboard ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
5 participants
@carmocca @ananthsub @awaelchli @justusschock @rohitgr7