Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metrics references from docs #10567

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Remove metrics references from docs #10567

merged 1 commit into from
Nov 22, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 16, 2021

What does this PR do?

Remove metrics references from docs

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
@awaelchli awaelchli enabled auto-merge (squash) November 17, 2021 02:19
@kaushikb11 kaushikb11 added this to the 1.6 milestone Nov 17, 2021
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #10567 (4db37f1) into master (eb13e1d) will decrease coverage by 4%.
The diff coverage is n/a.

❗ Current head 4db37f1 differs from pull request most recent head b20a503. Consider uploading reports for the commit b20a503 to get more accurate results

@@           Coverage Diff            @@
##           master   #10567    +/-   ##
========================================
- Coverage      92%      88%    -4%     
========================================
  Files         177      178     +1     
  Lines       16290    16248    -42     
========================================
- Hits        14948    14277   -671     
- Misses       1342     1971   +629     

@ananthsub
Copy link
Contributor

@kaushikb11 is there an issue for the docs revamp? It'd be nice to link all the PRs to that issue to see all the improvements made

@kaushikb11
Copy link
Contributor Author

Hey @ananthsub,

This sprint, we will be working on a proposal for a better docs structure. The original PR is here by Eden #7718 which was long back.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@awaelchli awaelchli merged commit 1284ead into master Nov 22, 2021
@awaelchli awaelchli deleted the remove/metrics branch November 22, 2021 14:29
rohitgr7 pushed a commit that referenced this pull request Nov 22, 2021
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
awaelchli pushed a commit that referenced this pull request Nov 24, 2021
@carmocca carmocca modified the milestones: 1.6, 1.5.x Nov 24, 2021
lexierule pushed a commit that referenced this pull request Nov 24, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants