Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't register signal in thread #10610

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Don't register signal in thread #10610

merged 5 commits into from
Nov 19, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 18, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #10336

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@tchaton tchaton added the bug Something isn't working label Nov 18, 2021
@tchaton tchaton added this to the 1.5.x milestone Nov 18, 2021
@tchaton tchaton self-assigned this Nov 18, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton mentioned this pull request Nov 18, 2021
Closed
awaelchli
awaelchli approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than @kaushikb11 comment LGTM

@mergify mergify bot added the ready PRs ready to be merged label Nov 18, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) November 18, 2021 17:39
@mergify mergify bot removed the has conflicts label Nov 18, 2021
@kaushikb11 kaushikb11 merged commit 7d3ad5b into master Nov 19, 2021
@kaushikb11 kaushikb11 deleted the bugfix_10336 branch November 19, 2021 03:13
@kaushikb11 kaushikb11 mentioned this pull request Nov 19, 2021
Closed
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@tchaton @Raalsky
Don't register signal in thread (Lightning-AI#10610)
9417f09
awaelchli added a commit that referenced this pull request Nov 24, 2021
@awaelchli @tchaton
Don't register signal in thread (#10610)
505f4ef 
Co-authored-by: tchaton <thomas@grid.ai>
awaelchli added a commit that referenced this pull request Nov 24, 2021
@awaelchli @tchaton
Don't register signal in thread (#10610)
7d35da1 
Co-authored-by: tchaton <thomas@grid.ai>
lexierule pushed a commit that referenced this pull request Nov 24, 2021
@awaelchli @tchaton @lexierule
Don't register signal in thread (#10610)
bfc0447 
Co-authored-by: tchaton <thomas@grid.ai>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
@eaplatanios eaplatanios mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@tchaton tchaton

Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.

v1.5.0 breaks wandb hyperparameter sweeps in Colab
5 participants
@tchaton @awaelchli @carmocca @rohitgr7 @kaushikb11