Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bug_report model links and notebook #10665

Merged
merged 4 commits into from
Nov 22, 2021
Merged

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 21, 2021

What does this PR do?

Removing outputs from bug_report notebook since they can be misleading sometimes.
Also Fixes: #10659

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@rohitgr7 rohitgr7 added this to the 1.5.x milestone Nov 21, 2021
@rohitgr7 rohitgr7 self-assigned this Nov 21, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mergify mergify bot added the ready PRs ready to be merged label Nov 22, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 enabled auto-merge (squash) November 22, 2021 10:13
@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #10665 (68f586a) into master (8ea39d2) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10665   +/-   ##
=======================================
- Coverage      92%      92%   -0%     
=======================================
  Files         178      177    -1     
  Lines       16293    16290    -3     
=======================================
- Hits        14951    14948    -3     
  Misses       1342     1342           

@rohitgr7 rohitgr7 merged commit eb13e1d into master Nov 22, 2021
@rohitgr7 rohitgr7 deleted the example/bug_report branch November 22, 2021 11:19
Raalsky pushed a commit to neptune-ai/pytorch-lightning that referenced this pull request Nov 23, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL to bug report is incorrect in Github issue template
7 participants