Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate state when retrieving sharded state dict in Lite #10746

Merged
merged 7 commits into from
Nov 27, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 25, 2021

What does this PR do?

Fixes #10745

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @carmocca @justusschock @awaelchli @SeanNaren

@awaelchli awaelchli added bug Something isn't working fabric lightning.fabric.Fabric labels Nov 25, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 25, 2021
@rohitgr7 rohitgr7 added the strategy: fairscale sharded (removed) Sharded Data Parallel label Nov 25, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !

@mergify mergify bot added the ready PRs ready to be merged label Nov 25, 2021
@mergify mergify bot removed the has conflicts label Nov 26, 2021
@awaelchli awaelchli enabled auto-merge (squash) November 27, 2021 04:31
@awaelchli awaelchli merged commit c752060 into master Nov 27, 2021
@awaelchli awaelchli deleted the bugfix/lite-optimizer-state branch November 27, 2021 04:54
awaelchli added a commit that referenced this pull request Nov 27, 2021
Co-authored-by: thomas chaton <thomas@grid.ai>
lexierule pushed a commit that referenced this pull request Nov 30, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fabric lightning.fabric.Fabric ready PRs ready to be merged strategy: fairscale sharded (removed) Sharded Data Parallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lite] Optimizer state has not been consolidated on this rank
5 participants