Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default logging levels for train step specific hooks #10756

Merged
merged 12 commits into from
Nov 29, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Nov 25, 2021

What does this PR do?

The following hooks had levels on_step=False and on_epoch=True by default:

on_train_batch_start
on_train_batch_end
on_before_backward
on_after_backward
on_before_optimizer_step
on_before_zero_grad

now they are logged with on_step=True and on_epoch=False by default. Also added a test to check for default levels for all hooks.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @carmocca @edward-io @ananthsub

@rohitgr7 rohitgr7 added bug Something isn't working logging Related to the `LoggerConnector` and `log()` labels Nov 25, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@rohitgr7 rohitgr7 mentioned this pull request Nov 25, 2021
12 tasks
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Nov 25, 2021
@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #10756 (af16094) into master (e507bc9) will decrease coverage by 0%.
The diff coverage is 94%.

❗ Current head af16094 differs from pull request most recent head 1801937. Consider uploading reports for the commit 1801937 to get more accurate results

@@           Coverage Diff           @@
##           master   #10756   +/-   ##
=======================================
- Coverage      92%      92%   -0%     
=======================================
  Files         177      177           
  Lines       16435    16397   -38     
=======================================
- Hits        15088    15052   -36     
+ Misses       1347     1345    -2     

@rohitgr7 rohitgr7 enabled auto-merge (squash) November 28, 2021 19:49
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

CHANGELOG.md Outdated Show resolved Hide resolved
rohitgr7 and others added 2 commits November 30, 2021 00:51
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Nov 29, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logging Related to the `LoggerConnector` and `log()` ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants