Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune Conda CI timeout and other minor improvements #10769

Merged
merged 24 commits into from
Nov 28, 2021
Merged

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 25, 2021

What does this PR do?

  • Fixes script to pin versions
  • Adds a per-test timeout of 2.5 minutes. We should avoid relying on the GitHub timeout, as they just kill the job and we miss out on the hanging stack trace.
  • Removes randomization of tests

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Nov 25, 2021
@carmocca carmocca self-assigned this Nov 25, 2021
@carmocca carmocca changed the base branch from master to test_ci November 26, 2021 16:37
@carmocca carmocca added this to the 1.5.x milestone Nov 26, 2021
@carmocca carmocca changed the title [Ignore: debugging] Fix Conda CI Tune Conda CI timeout and other minor improvements Nov 26, 2021
Base automatically changed from test_ci to master November 26, 2021 17:07
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Nov 26, 2021
@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #10769 (698eee1) into master (49d09aa) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10769   +/-   ##
=======================================
- Coverage      90%      90%   -0%     
=======================================
  Files         177      177           
  Lines       16491    16491           
=======================================
- Hits        14910    14907    -3     
- Misses       1581     1584    +3     

@carmocca carmocca enabled auto-merge (squash) November 28, 2021 16:12
@carmocca carmocca merged commit e1bf54c into master Nov 28, 2021
@carmocca carmocca deleted the ci/maybe-fix-conda branch November 28, 2021 17:58
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants