Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typing in pl.callbacks.lr_monitor #10802

Merged
merged 19 commits into from
Dec 22, 2021
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 29, 2021

What does this PR do?

Part of #7037

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda

@awaelchli awaelchli added callback: lr monitor docs Documentation related labels Nov 29, 2021
@awaelchli awaelchli added this to the 1.6 milestone Nov 29, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Ideally, this would be done in PyTorch.

pytorch_lightning/utilities/types.py Show resolved Hide resolved
pytorch_lightning/utilities/types.py Show resolved Hide resolved
pytorch_lightning/utilities/types.py Show resolved Hide resolved
@awaelchli awaelchli marked this pull request as ready for review December 21, 2021 02:45
@mergify mergify bot added the ready PRs ready to be merged label Dec 21, 2021
@awaelchli awaelchli enabled auto-merge (squash) December 22, 2021 03:16
@mergify mergify bot removed the has conflicts label Dec 22, 2021
@awaelchli awaelchli merged commit b6dd1a3 into master Dec 22, 2021
@awaelchli awaelchli deleted the refactor/typing/lr_monitor branch December 22, 2021 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
callback: lr monitor docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants