Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update notebooks submodule #10827

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Update notebooks submodule #10827

merged 1 commit into from
Nov 30, 2021

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Nov 29, 2021

What does this PR do?

Updates the notebooks submodule and docs config to explicitly filter in the notebook directories that we want.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Fixes #1

cc @Borda

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca
Copy link
Contributor

Do we need this in the bug-fix release? Set the appropriate milestone.

@mergify mergify bot added the ready PRs ready to be merged label Nov 29, 2021
@ethanwharris ethanwharris added this to the 1.5.x milestone Nov 29, 2021
@ethanwharris ethanwharris enabled auto-merge (squash) November 30, 2021 11:42
@ethanwharris ethanwharris merged commit af43250 into master Nov 30, 2021
@ethanwharris ethanwharris deleted the docs/update_submodule branch November 30, 2021 11:54
ethanwharris added a commit that referenced this pull request Nov 30, 2021
lexierule pushed a commit that referenced this pull request Nov 30, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for help
4 participants