-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate CI job for slow tests #10830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Not sure if it was discussed, but was it intentional to skip slow tests by default? This means locally all tests marked as slow don't run. Since locally we usually run only a subset of tests anyway, "slowness" doesn't play such a big role. And for debugging purposes, it may be good to have them run always. May I suggest to invert the current behavior? |
Skipping them by default is the point of adding Slow CI, otherwise, they get to run on all jobs and we get no speedup. |
You would make the default to run the slow tests and set PL_RUN_SLOW_TESTS=0 in the regular CI and Currently only the slow ci configuration sets the env variable. |
We would need 3 values:
I personally prefer the current default because I want to run the quick tests much more often than all tests, and the slowness of the slow tests (as a Mac user) makes them too painful. |
strategy: | ||
fail-fast: false | ||
matrix: | ||
os: [ubuntu-latest, macOS-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed that here we skip run on Windows and all minimal requirements?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I wanted to keep this light at first as we don't run many tests at the moment. These can be added later
What does this PR do?
Just 1 parametrization for the moment, we can always add more later if necessary.
If I forgot to mark a specific test as
slow=True
, feel free to commit or comment.Fixes #9086
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @carmocca @akihironitta @Borda