Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate CI job for slow tests #10830

Merged
merged 13 commits into from
Dec 1, 2021
Merged

Add separate CI job for slow tests #10830

merged 13 commits into from
Dec 1, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 29, 2021

What does this PR do?

Just 1 parametrization for the moment, we can always add more later if necessary.

If I forgot to mark a specific test as slow=True, feel free to commit or comment.

Fixes #9086

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Nov 29, 2021
@carmocca carmocca added this to the 1.6 milestone Nov 29, 2021
@carmocca carmocca self-assigned this Nov 29, 2021
.github/workflows/ci_test-slow.yml Outdated Show resolved Hide resolved
tests/utilities/test_auto_restart.py Show resolved Hide resolved
.github/workflows/ci_test-slow.yml Show resolved Hide resolved
.github/workflows/ci_test-slow.yml Show resolved Hide resolved
.github/workflows/ci_test-slow.yml Show resolved Hide resolved
tests/helpers/runif.py Show resolved Hide resolved
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

.github/workflows/ci_test-slow.yml Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
@carmocca carmocca enabled auto-merge (squash) December 1, 2021 17:58
@carmocca carmocca merged commit 2697704 into master Dec 1, 2021
@carmocca carmocca deleted the ci/slow branch December 1, 2021 19:58
@awaelchli
Copy link
Contributor

awaelchli commented Dec 1, 2021

Not sure if it was discussed, but was it intentional to skip slow tests by default? This means locally all tests marked as slow don't run. Since locally we usually run only a subset of tests anyway, "slowness" doesn't play such a big role. And for debugging purposes, it may be good to have them run always. May I suggest to invert the current behavior?

@carmocca
Copy link
Contributor Author

carmocca commented Dec 2, 2021

Skipping them by default is the point of adding Slow CI, otherwise, they get to run on all jobs and we get no speedup.

@awaelchli
Copy link
Contributor

You would make the default to run the slow tests and set

PL_RUN_SLOW_TESTS=0 in the regular CI and
PL_RUN_SLOW_TESTS=1 in the dedicated one.

Currently only the slow ci configuration sets the env variable.

@carmocca
Copy link
Contributor Author

carmocca commented Dec 2, 2021

We would need 3 values:

  1. Run only slow tests (current PL_RUN_SLOW_TESTS=1)
  2. Run only non-slow tests. Current default. (current PL_RUN_SLOW_TESTS=0)
  3. Run all tests. Suggested default. How do you propose we set it?

I personally prefer the current default because I want to run the quick tests much more often than all tests, and the slowness of the slow tests (as a Mac user) makes them too painful.

strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macOS-latest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed that here we skip run on Windows and all minimal requirements?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to keep this light at first as we don't run many tests at the moment. These can be added later

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow CI
5 participants