Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip hanging spawn tests #10838

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Skip hanging spawn tests #10838

merged 4 commits into from
Nov 30, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Nov 30, 2021

What does this PR do?

Since we haven't found a solution for all loggers, we've decided to skip these tests under the circumstances where they hang. This was attempted in #10826

That is torch<1.9 and Python>=3.8.

We don't expect this to be a problem for users as they won't be spawning as many processes together as we do when we run pytest.

Closes #10805

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Nope

cc @Borda

@carmocca carmocca added the tests label Nov 30, 2021
@carmocca carmocca added this to the 1.5.x milestone Nov 30, 2021
@carmocca carmocca self-assigned this Nov 30, 2021
@carmocca carmocca changed the title [WIP] Skip hanging spawn tests Skip hanging spawn tests Nov 30, 2021
@justusschock justusschock enabled auto-merge (squash) November 30, 2021 15:55
@mergify mergify bot added the ready PRs ready to be merged label Nov 30, 2021
@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #10838 (a013d79) into master (38ed26e) will decrease coverage by 0%.
The diff coverage is 36%.

@@           Coverage Diff           @@
##           master   #10838   +/-   ##
=======================================
- Coverage      90%      90%   -0%     
=======================================
  Files         177      177           
  Lines       16508    16512    +4     
=======================================
- Hits        14915    14910    -5     
- Misses       1593     1602    +9     

@awaelchli
Copy link
Contributor

@carmocca should we add the pytest-timeout also to the regular CPU tests?

@carmocca
Copy link
Contributor Author

should we add the pytest-timeout also to the regular CPU tests?

We totally can, but we haven't seen any hangs there at the moment. The current failures we have are caused by the MacOs tests actually hitting the global timeout because they are slow.

@awaelchli
Copy link
Contributor

Ok, I commented this only because I saw them timeout and feared that skipping the tests had global impact on others.

@carmocca
Copy link
Contributor Author

The "Slow CI" addition might alleviate that since the worker tests are particularly slow on MacOS.

@justusschock justusschock merged commit 8e1b9b3 into master Nov 30, 2021
@justusschock justusschock deleted the tests/skip-hanging-spawn branch November 30, 2021 18:36
@carmocca
Copy link
Contributor Author

Finally 😓

awaelchli added a commit that referenced this pull request Dec 1, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Dec 7, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants