-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip hanging spawn tests #10838
Skip hanging spawn tests #10838
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10838 +/- ##
=======================================
- Coverage 90% 90% -0%
=======================================
Files 177 177
Lines 16508 16512 +4
=======================================
- Hits 14915 14910 -5
- Misses 1593 1602 +9 |
@carmocca should we add the pytest-timeout also to the regular CPU tests? |
We totally can, but we haven't seen any hangs there at the moment. The current failures we have are caused by the MacOs tests actually hitting the global timeout because they are slow. |
Ok, I commented this only because I saw them timeout and feared that skipping the tests had global impact on others. |
The "Slow CI" addition might alleviate that since the worker tests are particularly slow on MacOS. |
Finally 😓 |
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
What does this PR do?
Since we haven't found a solution for all loggers, we've decided to skip these tests under the circumstances where they hang. This was attempted in #10826
That is
torch<1.9
andPython>=3.8
.We don't expect this to be a problem for users as they won't be spawning as many processes together as we do when we run
pytest
.Closes #10805
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Nope
cc @Borda