Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection of standalone tests #10857

Merged
merged 4 commits into from
Dec 1, 2021
Merged

Fix selection of standalone tests #10857

merged 4 commits into from
Dec 1, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 1, 2021

What does this PR do?

Current master branch does not run the standalone (previously known as special) tests. There is a bug with reading the STANDALONE_PATTERN environment variable. Instead of a env variable, we will now rely on standard pytest argument passing, e.g.,

bash tests/standalone_tests.sh -k deepspeed

to run all tests that have the word "deepspeed" in their name.

This fix should also be included in 1.5.5.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @tchaton @carmocca @akihironitta @Borda

@awaelchli awaelchli marked this pull request as ready for review December 1, 2021 00:21
@awaelchli awaelchli added ci Continuous Integration tests priority: 0 High priority task labels Dec 1, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Dec 1, 2021
@carmocca carmocca enabled auto-merge (squash) December 1, 2021 00:42
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch !

@mergify mergify bot added the ready PRs ready to be merged label Dec 1, 2021
@carmocca carmocca merged commit e6cc99e into master Dec 1, 2021
@carmocca carmocca deleted the ci/standalone-pattern branch December 1, 2021 08:48
awaelchli added a commit that referenced this pull request Dec 1, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Dec 7, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants