-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix retrieval of batch indices when dataloader num_workers > 0 #10870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
tchaton
reviewed
Dec 1, 2021
tchaton
approved these changes
Dec 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren and
williamFalcon
as code owners
December 1, 2021 22:07
awaelchli
commented
Dec 1, 2021
carmocca
approved these changes
Dec 2, 2021
rohitgr7
approved these changes
Dec 2, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #10870 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 177 177
Lines 16567 16579 +12
=======================================
+ Hits 15206 15218 +12
Misses 1361 1361 |
awaelchli
added a commit
that referenced
this pull request
Dec 2, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
Dec 7, 2021
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #10782
Please see my comment here #10782 (comment) for a detailed answer where the bug comes from and why we need to change the way we use the
IndexBatchSamplerWrapper
. In short, the way a PyTorch BatchSampler retrieves the batch indices differs betweennum_workers=0
andnum_workers > 0
in theDataLoader
, and our prediction loop needs to account for that.Does your PR introduce any breaking changes? If yes, please list them.
No.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda