-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeepSpeed] fix flag forwarding in DeepSpeedPlugin #10899
[DeepSpeed] fix flag forwarding in DeepSpeedPlugin #10899
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and appreciate the additional test!
Sounds good Co-authored-by: Sean Naren <sean@grid.ai>
Codecov Report
@@ Coverage Diff @@
## master #10899 +/- ##
========================================
- Coverage 92% 88% -4%
========================================
Files 177 177
Lines 16521 16521
========================================
- Hits 15162 14541 -621
- Misses 1359 1980 +621 |
Co-authored-by: ananthsub <ananth.subramaniam@gmail.com>
Head branch was pushed to by a user without write access
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sean Naren <sean@grid.ai> Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sean Naren <sean@grid.ai> Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Sean Naren <sean@grid.ai> Co-authored-by: ananthsub <ananth.subramaniam@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
What does this PR do?
Forward the cpu_checkpointing and contiguous_memory_optimization flags of DeepSpeedPlugin to deepspeed correctly. Previously we were ignoring these flags.
Fixes #10874
Before starting this issue I did not realize that contiguous_memory_optimization was also not forwarded, but the unit test showed it had a similar issue as cpu_checkpointing
Does your PR introduce any breaking changes? If yes, please list them.
I don't think so, but could do if deepspeed sometimes has problems with these flags (not found myself and I think this should be the expected behaviour).
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Yes 🙃