Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanity check for RichProgressBar #10913

Merged
merged 6 commits into from
Dec 15, 2021
Merged

Fix sanity check for RichProgressBar #10913

merged 6 commits into from
Dec 15, 2021

Conversation

kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Dec 3, 2021

What does this PR do?

Fixes sanity check for RichProgressBar

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

Fixes #1

cc @Borda @tchaton @SeanNaren @kaushikb11

@kaushikb11 kaushikb11 enabled auto-merge (squash) December 3, 2021 07:14
@awaelchli awaelchli added this to the 1.5.x milestone Dec 3, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would drop the test

@mergify mergify bot added ready PRs ready to be merged has conflicts labels Dec 3, 2021
@mergify mergify bot removed the has conflicts label Dec 14, 2021
@mergify mergify bot removed the has conflicts label Dec 15, 2021
@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #10913 (eed9dec) into master (23807c2) will increase coverage by 0%.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #10913   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         177      177           
  Lines       16490    16491    +1     
=======================================
+ Hits        15149    15160   +11     
+ Misses       1341     1331   -10     

@kaushikb11 kaushikb11 merged commit 5eecdca into master Dec 15, 2021
@kaushikb11 kaushikb11 deleted the fix/sanity_check_rich branch December 15, 2021 09:23
@rohitgr7 rohitgr7 modified the milestones: 1.5.x, 1.6 Dec 15, 2021
awaelchli added a commit that referenced this pull request Dec 15, 2021
@rohitgr7 rohitgr7 modified the milestones: 1.6, 1.5.x Dec 15, 2021
awaelchli added a commit that referenced this pull request Dec 15, 2021
Co-authored-by: Kaushik B <kaushikbokka@gmail.com>
rohitgr7 pushed a commit that referenced this pull request Dec 15, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority: 0 High priority task progress bar: rich ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal for help
5 participants