Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for CombinedLoader while checking for warning raised with eval dataloaders #10994

Merged
merged 2 commits into from
Dec 14, 2021

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Dec 8, 2021

What does this PR do?

Fixes #10866

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @ninginthecloud

@rohitgr7 rohitgr7 added bug Something isn't working data handling Generic data-related topic labels Dec 8, 2021
@rohitgr7 rohitgr7 added this to the 1.5.x milestone Dec 8, 2021
@rohitgr7 rohitgr7 self-assigned this Dec 8, 2021
@rohitgr7 rohitgr7 marked this pull request as ready for review December 8, 2021 12:05
@rohitgr7 rohitgr7 changed the title Fix support for CombinedLoader while checking for warning raised with eval dataloaders Fix support for CombinedLoader while checking for warning raised with eval dataloaders Dec 8, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Dec 9, 2021
@rohitgr7 rohitgr7 enabled auto-merge (squash) December 9, 2021 08:05
@rohitgr7 rohitgr7 merged commit 59ef66c into master Dec 14, 2021
@rohitgr7 rohitgr7 deleted the fix/eval_combine_dl branch December 14, 2021 15:13
rohitgr7 added a commit that referenced this pull request Dec 14, 2021
lexierule pushed a commit that referenced this pull request Dec 15, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning about shuffle=True despite having shuffle=False in multiple val_dataloader with CombinedLoader
4 participants