Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicated file extension when uploading model checkpoints with NeptuneLogger #11015

Merged
merged 2 commits into from
Dec 10, 2021

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Dec 9, 2021

What does this PR do?

When uploading model checkpoints with NeptuneLogger, ckpt files are created under some/namespace/model.ckpt (for instance) in metadata. When user downloads the file or explores the UI the filename is constructed in a form <last part of namespace>.<file extension> so in our case it will end up in model.ckpt.ckpt. This PR removes the extension from namespace which would consist of a filename model.ckpt without dupplicated file extension in filenames.

Preview:
before
after

Does your PR introduce any breaking changes? If yes, please list them.

Old scripts with Neptune loggers will consist of different metadata structure in Neptune.ai. Filenames after download are now the same as source filenames.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃
I'm pretty sure It makes me fun all the time 😉

@Raalsky Raalsky changed the title Extension removal when uploading with Neptune Logger Removed duplicated file extension when uploading model checkpoints with NeptuneLogger Dec 9, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@rohitgr7 rohitgr7 added this to the 1.5.x milestone Dec 10, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 10, 2021
@kamil-kaczmarek
Copy link
Contributor

@Raalsky
LGTM

@rohitgr7 rohitgr7 merged commit ed84cef into Lightning-AI:master Dec 10, 2021
@Raalsky Raalsky deleted the dev/file-extension branch December 10, 2021 21:26
awaelchli added a commit that referenced this pull request Dec 14, 2021
awaelchli added a commit that referenced this pull request Dec 14, 2021
…th NeptuneLogger (#11015)

Co-authored-by: Rafał Jankowski <raalsky@gmail.com>
lexierule pushed a commit that referenced this pull request Dec 15, 2021
…th NeptuneLogger (#11015)

Co-authored-by: Rafał Jankowski <raalsky@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
logger: neptune ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants