-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed NeptuneLogger when using DDP #11030
Conversation
37affb2
to
12f1c37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the quick fix!
One could consider adding Neptune to the parametrization of
tests/loggers/test_all.py::test_logger_created_on_rank_zero_only
Head branch was pushed to by a user without write access
Added 😉. Sorry, am I broke something (don't know about an active auto merge before committing)? :D |
Head branch was pushed to by a user without write access
0cfc1ca
to
b722d33
Compare
ac483e1
to
cca3840
Compare
Head branch was pushed to by a user without write access
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
It looks like a final state now 😉. @rohitgr7 @awaelchli 😉 Could you re-enable auto-merge? |
Head branch was pushed to by a user without write access
Codecov Report
@@ Coverage Diff @@
## master #11030 +/- ##
=======================================
Coverage 88% 88%
=======================================
Files 177 177
Lines 16526 16551 +25
=======================================
+ Hits 14580 14603 +23
- Misses 1946 1948 +2 |
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
What does this PR do?
Makes Neptune Experiment (Run in the scope of Neptune) initialization to be called only on rank == 0 in distributed environment. Should not introduce any breaking changes and was tested with previously pickled
NeptuneLogger
.Fixes #10604
And could resolve a few similar issues in external repositories:
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
Definitely ❤️