Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support torch 1.10.1 #11095

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Support torch 1.10.1 #11095

merged 2 commits into from
Dec 16, 2021

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Dec 16, 2021

What does this PR do?

Adds support for torch 1.10.1 in our CI.
Pins mypy as it also made a release. Will unpin in #11096
Fixes failing builds

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @tchaton @carmocca @akihironitta @Borda

@carmocca carmocca added the ci Continuous Integration label Dec 16, 2021
@carmocca carmocca added this to the 1.5.x milestone Dec 16, 2021
@carmocca carmocca self-assigned this Dec 16, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@carmocca carmocca enabled auto-merge (squash) December 16, 2021 01:20
@carmocca carmocca added the priority: 0 High priority task label Dec 16, 2021
@mergify mergify bot added the ready PRs ready to be merged label Dec 16, 2021
@carmocca
Copy link
Contributor Author

The failing docker image builds are unrelated and caused by a broken apex master: NVIDIA/apex#1252

@carmocca carmocca mentioned this pull request Dec 16, 2021
12 tasks
@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #11095 (db77e84) into master (3c4d06b) will increase coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #11095   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         177      177           
  Lines       16498    16502    +4     
=======================================
+ Hits        15166    15170    +4     
  Misses       1332     1332           

@carmocca carmocca merged commit 9e56290 into master Dec 16, 2021
@carmocca carmocca deleted the ci/new-torch branch December 16, 2021 03:23
awaelchli pushed a commit that referenced this pull request Dec 16, 2021
lexierule pushed a commit that referenced this pull request Dec 21, 2021
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants