-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AttributeError when using CombinedLoader in prediction #11111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
added
bug
Something isn't working
data handling
Generic data-related topic
trainer: predict
labels
Dec 16, 2021
awaelchli
changed the title
Fix AttributeError when using CombinedDataLoader in prediction
Fix AttributeError when using CombinedLoader in prediction
Dec 16, 2021
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
December 16, 2021 23:16
rohitgr7
reviewed
Dec 17, 2021
justusschock
approved these changes
Dec 17, 2021
carmocca
approved these changes
Dec 17, 2021
rohitgr7
approved these changes
Dec 17, 2021
Borda
approved these changes
Dec 17, 2021
rohitgr7
pushed a commit
that referenced
this pull request
Dec 18, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
Dec 21, 2021
Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
data handling
Generic data-related topic
ready
PRs ready to be merged
trainer: predict
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #11062
This is a partial fix to enable prediction with CombinedLoader without tracked sample indices until we figure out how we support batch_sampler with CombinedLoader.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda @justusschock @awaelchli @ninginthecloud