Remove LoggerConnector.on_trainer_init
#11121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves property initialization to trainer - Adds typehints for affected flags on the Trainer
ananthsub
requested review from
awaelchli,
carmocca,
tchaton and
williamFalcon
as code owners
awaelchli
reviewed
Dec 17, 2021
| @@ -48,25 +46,6 @@ def __init__(self, trainer: "pl.Trainer", log_gpu_memory: Optional[str] = None) | |||
| self._batch_idx: Optional[int] = None | |||
| self._split_idx: Optional[int] = None | |||
|
|
|||
| def on_trainer_init( | |||
There was a problem hiding this comment.
In #10417 we propose to make the logger owned by the connector. The two methods on_trainer_init and configure_logger would then essentially become part of the LoggerConnector init without reference to the trainer. What are your thoughts?
There was a problem hiding this comment.
I would definitely prefer this approach. Right now, the Trainer is starting to become a bigger class and it is getting harder for users to parse it.
carmocca
reviewed
Dec 17, 2021
| @@ -569,9 +569,9 @@ def __init__( | |||
| # configure profiler | |||
| self.__init_profiler(profiler) | |||
|
|
|||
| # init logger flags | |||
| # configure logger flags | |||
| self.logger: Optional[LightningLoggerBase] | |||
There was a problem hiding this comment.
I played a bit with this and this definition needs to be in the __init__, otherwise mypy will treat it as Any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to comment here: https://github.com/PyTorchLightning/pytorch-lightning/pull/11114/files#r771039150
Part of #7037, #10417
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃