Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip testing with PyTorch 1.7 and Python 3.9 on Ubuntu #11217

Merged
merged 68 commits into from
Jan 7, 2022
Merged

Skip testing with PyTorch 1.7 and Python 3.9 on Ubuntu #11217

Changes from all commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
886f1b7
[skip azpipelines]
akihironitta Dec 22, 2021
7c2d096
Merge branch 'master' into ci/fix-segfault
akihironitta Dec 22, 2021
a3764c3
Disable coverage
akihironitta Dec 22, 2021
99ab83c
python -X faulthander
akihironitta Dec 26, 2021
1c99eeb
pytest -p no:faulthandler
akihironitta Dec 26, 2021
65fd952
revert python's faulthandler
akihironitta Dec 27, 2021
7fe8c96
gdb
akihironitta Dec 27, 2021
97202d3
Merge branch 'master' into ci/fix-segfault
akihironitta Dec 27, 2021
46f9ae0
install gdb
akihironitta Dec 27, 2021
871ae6b
pytest --color=no for visibility in raw log
akihironitta Dec 27, 2021
24fb084
suppress pytest output and return its status
akihironitta Dec 27, 2021
a476ef2
Simplify pytest options under gdb
akihironitta Dec 27, 2021
b88c257
[azp skip]
akihironitta Dec 27, 2021
1317ba0
Temporarily disable example tests and uploading results
akihironitta Dec 27, 2021
10ec844
echo after tests
akihironitta Dec 27, 2021
baf2bf8
fix illegal option -f on macos
akihironitta Dec 27, 2021
ca1c639
execute command running under gdb for checking if working
akihironitta Dec 27, 2021
cc37fd0
enable gdb again
akihironitta Dec 28, 2021
7995994
Temporarily disable win and mac
akihironitta Dec 28, 2021
4906fe8
Merge branch 'master' into ci/fix-segfault
akihironitta Jan 6, 2022
999d01d
Temporarily rm horovod installation
akihironitta Jan 6, 2022
3c55405
tmp: no reinstallation of horovod
akihironitta Jan 6, 2022
3494f10
disable gdb for clean output
akihironitta Jan 6, 2022
ebe3af1
Revert "disable gdb for clean output"
akihironitta Jan 6, 2022
e766a29
[skip azp] wish the latest pytest somehow works
akihironitta Jan 6, 2022
d8cabe7
[skip azp] Don't use old versions of packages for testing
akihironitta Jan 6, 2022
7ca993c
[skip azp] disable gdb for clean output
akihironitta Jan 6, 2022
73f78f0
[skip azp] python -X faulthandler with typo fixed (redo of 99ab83c)
akihironitta Jan 6, 2022
aaaf7d1
[skip azp] enable gdb
akihironitta Jan 6, 2022
e61abc1
Temporarily disable all other CI jobs
akihironitta Jan 6, 2022
4dde7e8
split into doctests and tests
akihironitta Jan 6, 2022
fd8ee63
split tests into subdirectories
akihironitta Jan 6, 2022
eb4fe89
Fix 'split tests into subdirectories'
akihironitta Jan 6, 2022
dcd67ed
Fix 'split tests into subdirectories'
akihironitta Jan 6, 2022
8213659
Disable tests unrelated to segfault
akihironitta Jan 6, 2022
cdc1bb1
use ubuntu20.04
akihironitta Jan 6, 2022
f1a7996
uninstall horovod
akihironitta Jan 6, 2022
ea4d419
_HOROVOD_AVAILABLE = False
akihironitta Jan 6, 2022
b048c9b
run tests/callbacks and then tests/accelerators
akihironitta Jan 6, 2022
3d52b34
Add a fake test
akihironitta Jan 6, 2022
a5721a4
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 6, 2022
e05effd
Update .github/workflows/ci_test-full.yml
carmocca Jan 6, 2022
61fbd2b
Move foo test with callbacks tests
carmocca Jan 6, 2022
b73261e
Revert Horovod changes
carmocca Jan 6, 2022
b70319b
Just foo worked
carmocca Jan 6, 2022
306676e
Trim down steps
carmocca Jan 6, 2022
3eba49e
Just test_callbaks.py worked
carmocca Jan 6, 2022
adc4a59
Fix rich bug
carmocca Jan 6, 2022
814f2fe
tests/callbacks failed. try now each file separately
carmocca Jan 6, 2022
d1b595d
Narrow down
carmocca Jan 6, 2022
3f34ca5
Narrow down
carmocca Jan 6, 2022
a741f63
Need the local import
carmocca Jan 6, 2022
24e3645
Try bug_report_model with pytest
carmocca Jan 6, 2022
30e1d88
Clean unused code
carmocca Jan 6, 2022
2cb5f91
Try SSH
carmocca Jan 6, 2022
a85861a
Disable checkpointing
carmocca Jan 6, 2022
34a16f2
Narrow down
carmocca Jan 6, 2022
fe84e8d
empty commit for rerun ci
akihironitta Jan 7, 2022
0560e77
Revert "use ubuntu20.04"
akihironitta Jan 7, 2022
9ad12b8
Undo unrelated changes
akihironitta Jan 7, 2022
42aa328
Revert "pytest --color=no for visibility in raw log"
akihironitta Jan 7, 2022
a71ee32
Undo unrelated change - set-min-requirements.py
akihironitta Jan 7, 2022
beafe53
Revert "Fix rich bug"
akihironitta Jan 7, 2022
bc569bc
revert bug_report_model
akihironitta Jan 7, 2022
5e2508c
revert foo test
akihironitta Jan 7, 2022
b8c0bcd
Skip (ubuntu, py3.9, oldest)
akihironitta Jan 7, 2022
e48738d
Revert "Temporarily disable all other CI jobs"
akihironitta Jan 7, 2022
fc8f3c3
Enable testing on mac and win
akihironitta Jan 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci_test-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ jobs:
python-version: ["3.7", "3.9"] # minimum, maximum
requires: ["oldest", "latest"]
release: ["stable"]
exclude:
# Skip if torch<1.8 and py3.9 on Linux: https://github.com/pytorch/pytorch/issues/50014
- {os: ubuntu-18.04, python-version: "3.9", requires: "oldest", release: "stable"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, I would not run any oldest for py3.9

- {python-version: "3.9", requires: "oldest"}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda Could I ask why you wouldn't? This problem shouldn't apply to other oldest settings.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use release: "stable" is redundant since we do not have other release values then stable now
and in general, if someone is using almost the latest python I don't think he would assist on the oldest packages...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use release: "stable" is redundant since we do not have other release values then stable now

👍

in general, if someone is using almost the latest python I don't think he would assist on the oldest packages...

I see your point. I've just created an issue #11367 to gain some visibility on this.

#include:
# nightly: add when there's a release candidate
#- {os: ubuntu-20.04, python-version: "3.10", requires: "latest", release: "pre"}
Expand Down