-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix data fetcher selection #11294
Fix data fetcher selection #11294
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to add a test for the fix?
The data fetcher code and inter-batch parallelism is untested as far as I know. The Trainer and connectors are currently not well unit-testable, I predict this code will not survive very long and I would avoid adding tests for checking internal attributes that get set this way. |
Codecov Report
@@ Coverage Diff @@
## master #11294 +/- ##
=======================================
Coverage 92% 92%
=======================================
Files 177 177
Lines 16840 16840
=======================================
Hits 15479 15479
Misses 1361 1361 |
@awaelchli shall we cover it by a test? |
What does this PR do?
Fixes #11266
What does this PR do?
Fixes
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @Borda @justusschock @awaelchli @ninginthecloud