Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data fetcher selection #11294

Merged
merged 2 commits into from
Jan 3, 2022
Merged

Fix data fetcher selection #11294

merged 2 commits into from
Jan 3, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jan 3, 2022

What does this PR do?

Fixes #11266

What does this PR do?

Fixes

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda @justusschock @awaelchli @ninginthecloud

@awaelchli awaelchli added bug Something isn't working data handling Generic data-related topic labels Jan 3, 2022
@awaelchli awaelchli added this to the 1.5.x milestone Jan 3, 2022
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a test for the fix?

@awaelchli
Copy link
Contributor Author

The data fetcher code and inter-batch parallelism is untested as far as I know. The Trainer and connectors are currently not well unit-testable, I predict this code will not survive very long and I would avoid adding tests for checking internal attributes that get set this way.

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #11294 (a4a6090) into master (1fc046c) will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #11294   +/-   ##
=======================================
  Coverage      92%      92%           
=======================================
  Files         177      177           
  Lines       16840    16840           
=======================================
  Hits        15479    15479           
  Misses       1361     1361           

@mergify mergify bot added the ready PRs ready to be merged label Jan 3, 2022
@Borda
Copy link
Member

Borda commented Jan 3, 2022

@awaelchli shall we cover it by a test?

@carmocca carmocca merged commit 17cb3c7 into master Jan 3, 2022
@carmocca carmocca deleted the bugfix/getattr-datafetcher branch January 3, 2022 12:49
rohitgr7 pushed a commit that referenced this pull request Jan 4, 2022
awaelchli added a commit that referenced this pull request Jan 4, 2022
awaelchli added a commit that referenced this pull request Jan 5, 2022
awaelchli added a commit that referenced this pull request Jan 5, 2022
lexierule pushed a commit that referenced this pull request Jan 5, 2022
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data handling Generic data-related topic ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential bug in DataConnector?
5 participants