Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin sphinx-autodoc-typehints with <v1.15 #11400

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Pin sphinx-autodoc-typehints with <v1.15 #11400

merged 2 commits into from
Jan 10, 2022

Conversation

rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Jan 10, 2022

What does this PR do?

Fix temp: #11400

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7 @carmocca @akihironitta

@rohitgr7 rohitgr7 modified the milestones: 1.6, 1.5.x Jan 10, 2022
@rohitgr7 rohitgr7 changed the title Fix profiler doc Pin sphinx-autodoc-typehints with <v1.15 Jan 10, 2022
@rohitgr7 rohitgr7 added ci Continuous Integration docs Documentation related labels Jan 10, 2022
@rohitgr7 rohitgr7 marked this pull request as ready for review January 10, 2022 21:07
@rohitgr7 rohitgr7 enabled auto-merge (squash) January 10, 2022 21:11
Copy link
Member

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small suggestion

requirements/docs.txt Outdated Show resolved Hide resolved
Co-authored-by: Ethan Harris <ewah1g13@soton.ac.uk>
@mergify mergify bot added the ready PRs ready to be merged label Jan 10, 2022
@rohitgr7 rohitgr7 merged commit 34c62da into master Jan 10, 2022
@rohitgr7 rohitgr7 deleted the docs/prof_imp branch January 10, 2022 23:12
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration docs Documentation related ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants