Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move data fetcher ownership to the loops #11621

Merged
merged 11 commits into from
Feb 9, 2022
Merged

Move data fetcher ownership to the loops #11621

merged 11 commits into from
Feb 9, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 25, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Advantages:

  • Users can now customize fetching via loop customization.
  • Each loop controls it's own fetcher logic.
  • Removes clutter from the data connector.

Part of #11538

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @ninginthecloud @carmocca @ananthsub

@carmocca carmocca added refactor data handling Generic data-related topic loops Related to the Loop API labels Jan 25, 2022
@carmocca carmocca added this to the 1.6 milestone Jan 25, 2022
@carmocca carmocca self-assigned this Jan 25, 2022
Base automatically changed from feat/teardown-all to master February 2, 2022 21:10
@carmocca carmocca marked this pull request as ready for review February 2, 2022 21:26
@mergify mergify bot added the has conflicts label Feb 3, 2022
@mergify mergify bot removed the has conflicts label Feb 3, 2022
rohitgr7
rohitgr7 approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

rohitgr7
rohitgr7 approved these changes Feb 4, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all green 👏

@mergify mergify bot added the has conflicts label Feb 5, 2022
@mergify mergify bot removed the has conflicts label Feb 7, 2022
@carmocca carmocca enabled auto-merge (squash) February 8, 2022 17:19
tchaton
tchaton approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

pytorch_lightning/loops/fit_loop.py Show resolved Hide resolved
@tchaton tchaton added the ready PRs ready to be merged label Feb 9, 2022
kaushikb11
kaushikb11 approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@kaushikb11 kaushikb11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cleanup!

@carmocca carmocca merged commit 8394770 into master Feb 9, 2022
@carmocca carmocca deleted the refactor/move-fetchers branch February 9, 2022 14:34
@carmocca carmocca mentioned this pull request Feb 10, 2022
Closed
@ananthsub ananthsub mentioned this pull request Feb 16, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ananthsub ananthsub ananthsub left review comments

@tchaton tchaton tchaton approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

@awaelchli awaelchli Awaiting requested review from awaelchli

@Borda Borda Awaiting requested review from Borda Borda is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
data handling Generic data-related topic loops Related to the Loop API ready PRs ready to be merged refactor
Projects
None yet
Milestone
pl:1.6
Development

Successfully merging this pull request may close these issues.
5 participants
@carmocca @ananthsub @tchaton @rohitgr7 @kaushikb11