Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace meta_tags.csv with hparams.yaml #1268

Conversation

S-aiueo32
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1212.

@pep8speaks
Copy link

Hello @S-aiueo32! Thanks for opening this PR.

Line 70:69: W292 no newline at end of file

Line 60:8: E111 indentation is not a multiple of four

Line 340:111: E501 line too long (115 > 110 characters)

Do see the Hitchhiker's guide to code style

@S-aiueo32
Copy link
Contributor Author

Oh, I have a lot of mistakes with git. I close once.

@S-aiueo32 S-aiueo32 closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for loading flattened meta_tags.csv
3 participants