-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tests related to DDP communication hooks #12878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akihironitta
requested review from
williamFalcon,
Borda,
tchaton,
SeanNaren,
carmocca,
awaelchli,
justusschock,
kaushikb11 and
rohitgr7
as code owners
April 26, 2022 01:46
for more information, see https://pre-commit.ci
12 tasks
carmocca
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Borda
approved these changes
Apr 27, 2022
kaushikb11
approved these changes
Apr 27, 2022
carmocca
pushed a commit
that referenced
this pull request
Apr 27, 2022
* Fix ddp_comm_hook tests * Refactor ddp_comm_hook tests Co-authored-by: Akihiro Nitta <akihiro@pytorchlightning.ai>
5 tasks
lexierule
pushed a commit
that referenced
this pull request
May 3, 2022
* Fix ddp_comm_hook tests * Refactor ddp_comm_hook tests Co-authored-by: Akihiro Nitta <akihiro@pytorchlightning.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #12373.
Fixes DDP communication hook tests that are not running in our current CI setup.
Description of the changes
DistributedDataParallel.get_ddp_logging_data()
which only works withtorch<1.9
. In newer PyTorch, it's renamed toDistributedDataParallel._get_ddp_logging_data() -> Dict
.DDPStrategy.teardown
becauseDistributedDataParallel
is not available aftertrainer.fit()
runs as it gets removed during its teardown (related to [bugfix] Reduce memory leaks #8490).How to verify the changes
Note that the modified tests don't run in this PR. To verify the changes here, please either
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @Borda @akihironitta @justusschock @kaushikb11 @awaelchli @rohitgr7