Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple pulling legacy checkpoints from existing GHA workflows and docker files #13185

Merged
merged 5 commits into from
Jun 2, 2022
Merged

Decouple pulling legacy checkpoints from existing GHA workflows and docker files #13185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
21713e6
Add pull-legacy-checkpoints action
akihironitta May 31, 2022
4e7d5ef
Replace pulls with the new action and script
akihironitta May 31, 2022
6622cea
Simplify
akihironitta May 31, 2022
ecaf9d2
mv .github/scripts/ to .actions
akihironitta May 31, 2022
69d8f7f
Merge branch 'master' into ci/create-github-scripts
akihironitta May 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .actions/pull_legacy_checkpoints.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash
# Run this script from the project root.
URL="https://pl-public-data.s3.amazonaws.com/legacy/checkpoints.zip"
mkdir -p legacy
# wget is simpler but does not work on Windows
python -c "from urllib.request import urlretrieve; urlretrieve('$URL', 'legacy/checkpoints.zip')"
ls -l legacy/
unzip -o legacy/checkpoints.zip -d legacy/
ls -l legacy/checkpoints/
5 changes: 1 addition & 4 deletions .azure-pipelines/gpu-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,7 @@ jobs:
python requirements/check-avail-extras.py
displayName: 'Env details'

- bash: |
wget https://pl-public-data.s3.amazonaws.com/legacy/checkpoints.zip -P legacy/
unzip -o legacy/checkpoints.zip -d legacy/
ls -l legacy/checkpoints/
- bash: bash .actions/pull_legacy_checkpoints.sh
displayName: 'Get legacy checkpoints'

- bash: |
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/ci_test-conda.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,8 @@ jobs:
# sanity check
python requirements/check-avail-extras.py

- name: Pull checkpoints from S3
working-directory: ./legacy
run: |
# enter legacy and update checkpoints from S3
curl https://pl-public-data.s3.amazonaws.com/legacy/checkpoints.zip --output checkpoints.zip
unzip -o checkpoints.zip
ls -l checkpoints/
- name: Pull legacy checkpoints
run: bash .actions/pull_legacy_checkpoints.sh

- name: Tests
run: |
Expand Down
10 changes: 2 additions & 8 deletions .github/workflows/ci_test-full.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,8 @@ jobs:
restore-keys: |
${{ runner.os }}-pip-td${{ env.TIME_PERIOD }}-py${{ matrix.python-version }}-${{ matrix.release }}-${{ matrix.requires }}-

- name: Pull checkpoints from S3
working-directory: ./legacy
run: |
# wget is simpler but does not work on Windows
python -c "from urllib.request import urlretrieve ; urlretrieve('https://pl-public-data.s3.amazonaws.com/legacy/checkpoints.zip', 'checkpoints.zip')"
ls -l .
unzip -o checkpoints.zip
ls -l checkpoints/
- name: Pull legacy checkpoints
run: bash .actions/pull_legacy_checkpoints.sh

- name: Install dependencies
run: |
Expand Down
5 changes: 1 addition & 4 deletions dockers/tpu-tests/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,7 @@ LABEL maintainer="PyTorchLightning <https://github.com/PyTorchLightning>"
COPY ./ ./pytorch-lightning/

# Pull the legacy checkpoints
RUN cd pytorch-lightning && \
wget https://pl-public-data.s3.amazonaws.com/legacy/checkpoints.zip -P legacy/ && \
unzip -o legacy/checkpoints.zip -d legacy/ && \
ls -l legacy/checkpoints/
RUN cd pytorch-lightning && bash .actions/pull_legacy_checkpoints.sh

RUN \
pip install -q fire && \
Expand Down
3 changes: 1 addition & 2 deletions legacy/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ At this moment we focus on ability running old checkpoints, so the flow here is
If you want to pull all saved version-checkpoints for local testing/development, call

```bash
wget https://pl-public-data.s3.amazonaws.com/legacy/checkpoints.zip
unzip -o checkpoints.zip
bash .actions/pull_legacy_checkpoints.sh
```

To back populate collection with past version you can use following bash:
Expand Down
3 changes: 1 addition & 2 deletions tests/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ pre-commit install
Additionally, for testing backward compatibility with older versions of PyTorch Lightning, you also need to download all saved version-checkpoints from the public AWS storage. Run the following script to get all saved version-checkpoints:

```bash
wget https://pl-public-data.s3.amazonaws.com/legacy/checkpoints.zip -P legacy/
unzip -o legacy/checkpoints.zip -d legacy/
bash .actions/pull_legacy_checkpoints.sh
```

Note: These checkpoints are generated to set baselines for maintaining backward compatibility with legacy versions of PyTorch Lightning. Details of checkpoints for back-compatibility can be found [here](https://github.com/PyTorchLightning/pytorch-lightning/blob/master/legacy/README.md).
Expand Down