Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for incorrect run on the validation set with overwritten validation_epoch_end and test_end #1353

Merged
merged 5 commits into from
Apr 3, 2020
Merged

Fix for incorrect run on the validation set with overwritten validation_epoch_end and test_end #1353

merged 5 commits into from
Apr 3, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 2, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs? (not needed)
  • Did you write any new necessary tests? (no new test, only fixing an old one related to this bug)
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1262.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 2, 2020 23:32
@Borda Borda changed the title [WIP] Fix for #1262 [WIP] Fix for incorrect run on the test set with overwritten validation_end and test_epoch_end Apr 2, 2020
@Borda Borda added the bug Something isn't working label Apr 2, 2020
@pep8speaks
Copy link

pep8speaks commented Apr 3, 2020 •
edited
Loading

Hello @awaelchli! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-03 01:57:41 UTC

@awaelchli awaelchli changed the title [WIP] Fix for incorrect run on the test set with overwritten validation_end and test_epoch_end [WIP] Fix for incorrect run on the validation set with overwritten validation_epoch_end and test_end Apr 3, 2020
@awaelchli awaelchli changed the title [WIP] Fix for incorrect run on the validation set with overwritten validation_epoch_end and test_end Fix for incorrect run on the validation set with overwritten validation_epoch_end and test_end Apr 3, 2020
@awaelchli awaelchli marked this pull request as ready for review April 3, 2020 01:58
@justusschock justusschock requested a review from a team April 3, 2020 05:18
Borda
Borda approved these changes Apr 3, 2020
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Borda Borda added this to the 0.7.2 milestone Apr 3, 2020
@Borda Borda added the ready PRs ready to be merged label Apr 3, 2020
@Borda Borda requested a review from a team April 3, 2020 07:25
@williamFalcon williamFalcon merged commit ebd9fc9 into Lightning-AI:master Apr 3, 2020
@awaelchli awaelchli deleted the fix-mixed-naming-test branch April 4, 2020 01:33
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 4, 2020
Fix for incorrect run on the validation set with overwritten validati…
792ec3e 
…on_epoch_end and test_end (Lightning-AI#1353)

* reorder if clauses

* fix wrong method overload in test

* fix formatting

* update change_log

* fix line too long
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@tullie
Fix for incorrect run on the validation set with overwritten validati…
bcae6b8 
…on_epoch_end and test_end (Lightning-AI#1353)

* reorder if clauses

* fix wrong method overload in test

* fix formatting

* update change_log

* fix line too long
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justusschock justusschock justusschock approved these changes

@Borda Borda Borda approved these changes

Assignees
No one assigned
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

incorrect run on the test set with overwritten validation_end and test_epoch_end
5 participants
@awaelchli @pep8speaks @Borda @justusschock @williamFalcon