-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ddp_notebook alias for ddp_fork #13744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
carmocca
approved these changes
Jul 20, 2022
awaelchli
requested review from
tchaton,
SeanNaren,
Borda,
justusschock,
kaushikb11,
edenlightning,
Felonious-Spellfire,
williamFalcon and
rohitgr7
as code owners
July 22, 2022 16:29
Codecov Report
@@ Coverage Diff @@
## master #13744 +/- ##
=========================================
- Coverage 86% 76% -10%
=========================================
Files 327 327
Lines 25560 25562 +2
=========================================
- Hits 21969 19523 -2446
- Misses 3591 6039 +2448 |
Borda
approved these changes
Jul 22, 2022
justusschock
approved these changes
Jul 23, 2022
akihironitta
approved these changes
Jul 23, 2022
11 tasks
awaelchli
added
strategy: ddp
DistributedDataParallel
and removed
strategy: ddp spawn
labels
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
Is an improvement or enhancement
pl
Generic label for PyTorch Lightning package
ready
PRs ready to be merged
strategy: ddp
DistributedDataParallel
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up to #13405
After introducing the DDP Fork method, we can add a user-friendly alias "ddp_notebook" for the primary use case in Jupyter notebooks. This was requested internally (for those who have access).
It is just an alias in the registry. There will be a different PR that adds auto-detection in Jupyter notebooks.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7