Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ddp_notebook alias for ddp_fork #13744

Merged
merged 64 commits into from
Jul 23, 2022
Merged

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 19, 2022

What does this PR do?

Follow up to #13405

After introducing the DDP Fork method, we can add a user-friendly alias "ddp_notebook" for the primary use case in Jupyter notebooks. This was requested internally (for those who have access).
It is just an alias in the registry. There will be a different PR that adds auto-detection in Jupyter notebooks.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @justusschock @kaushikb11 @awaelchli @akihironitta @rohitgr7

@awaelchli awaelchli added this to the pl:1.7 milestone Jul 20, 2022
Base automatically changed from feature/ddp-fork2 to master July 22, 2022 16:05
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #13744 (177c19b) into master (c3299d2) will decrease coverage by 10%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13744     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         327      327             
  Lines       25560    25562      +2     
=========================================
- Hits        21969    19523   -2446     
- Misses       3591     6039   +2448     

@mergify mergify bot added the ready PRs ready to be merged label Jul 22, 2022
@awaelchli awaelchli merged commit d24978b into master Jul 23, 2022
@awaelchli awaelchli deleted the feature/ddp-fork2-notebook branch July 23, 2022 13:06
@awaelchli awaelchli added strategy: ddp DistributedDataParallel and removed strategy: ddp spawn labels Nov 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement pl Generic label for PyTorch Lightning package ready PRs ready to be merged strategy: ddp DistributedDataParallel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants