Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub links to PL repo #13849

Merged
merged 13 commits into from
Jul 28, 2022
Merged

Update GitHub links to PL repo #13849

merged 13 commits into from
Jul 28, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Jul 26, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Updates all links https://github.com/PyTorchLightning/pytorch-lightning to https://github.com/Lightning-AI/ightning and fixes one or two broken ones found along the way.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda @rohitgr7

@awaelchli awaelchli added the docs Documentation related label Jul 26, 2022
@awaelchli awaelchli added this to the pl:1.6.x milestone Jul 26, 2022
@awaelchli awaelchli marked this pull request as ready for review July 26, 2022 12:19
@codecov
Copy link

codecov bot commented Jul 26, 2022 •
edited
Loading

Codecov Report

Merging #13849 (4bfa715) into master (511875e) will decrease coverage by 1%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #13849    +/-   ##
========================================
- Coverage      86%      86%    -1%     
========================================
  Files         332      335     +3     
  Lines       26123    26613   +490     
========================================
+ Hits        22478    22766   +288     
- Misses       3645     3847   +202

rohitgr7
rohitgr7 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to ignore some of them. Can be done in a followup.

README.md Outdated Show resolved Hide resolved
docs/source-pytorch/starter/installation.rst Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/source-pytorch/starter/installation.rst Outdated Show resolved Hide resolved
tests/README.md Outdated Show resolved Hide resolved
src/pytorch_lightning/README.md Outdated Show resolved Hide resolved
src/pytorch_lightning/README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/pytorch_lightning/README.md Outdated Show resolved Hide resolved
@mergify mergify bot added the ready PRs ready to be merged label Jul 26, 2022
awaelchli and others added 3 commits July 26, 2022 08:48
@awaelchli @rohitgr7
Apply suggestions from code review
e573846 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@awaelchli @rohitgr7
Update src/pytorch_lightning/README.md
cf5cf79 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@awaelchli @rohitgr7
Update src/pytorch_lightning/README.md
8db5c3c 
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Jul 27, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels Jul 27, 2022
rohitgr7
rohitgr7 reviewed Jul 28, 2022
View reviewed changes
src/pytorch_lightning/README.md Outdated Show resolved Hide resolved
src/pytorch_lightning/README.md Outdated Show resolved Hide resolved
src/pytorch_lightning/README.md Outdated Show resolved Hide resolved
@akihironitta akihironitta mentioned this pull request Jul 28, 2022
Merged
9 tasks
akihironitta
akihironitta approved these changes Jul 28, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
src/pytorch_lightning/README.md Outdated Show resolved Hide resolved
@akihironitta akihironitta enabled auto-merge (squash) July 28, 2022 19:48
@carmocca carmocca modified the milestones: pl:1.6.x, pl:1.7 Jul 28, 2022
tchaton
tchaton approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@akihironitta akihironitta merged commit 7708ce2 into master Jul 28, 2022
@akihironitta akihironitta deleted the docs/link-updates branch July 28, 2022 20:08
Borda pushed a commit that referenced this pull request Jul 29, 2022
@awaelchli @Borda
Update GitHub links to PL repo (#13849)
53a0d30 
* update lightning links in docs

* update links in chlog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update src/pytorch_lightning/README.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update src/pytorch_lightning/README.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* update

* painful

* badges

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update badges

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

(cherry picked from commit 7708ce2)
lexierule pushed a commit that referenced this pull request Aug 1, 2022
@awaelchli @lexierule
Update GitHub links to PL repo (#13849)
f57d736 
* update lightning links in docs

* update links in chlog

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update src/pytorch_lightning/README.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* Update src/pytorch_lightning/README.md

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* update

* painful

* badges

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update badges

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
Co-authored-by: Jirka <jirka.borovec@seznam.cz>
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

(cherry picked from commit 7708ce2)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@akihironitta akihironitta akihironitta approved these changes

@Borda Borda Borda approved these changes

@tchaton tchaton tchaton approved these changes

@carmocca carmocca carmocca approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon is a code owner

@edenlightning edenlightning Awaiting requested review from edenlightning

@manskx manskx Awaiting requested review from manskx

@hhsecond hhsecond Awaiting requested review from hhsecond

@Felonious-Spellfire Felonious-Spellfire Awaiting requested review from Felonious-Spellfire

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

Assignees
No one assigned
Labels
docs Documentation related ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.7
Development

Successfully merging this pull request may close these issues.
6 participants
@awaelchli @Borda @carmocca @tchaton @akihironitta @rohitgr7