Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docs for LightningModule #1389

Merged
merged 4 commits into from
Apr 6, 2020
Merged

Improved docs for LightningModule #1389

merged 4 commits into from
Apr 6, 2020

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Apr 6, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests? (not needed)
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Most of the changes are

  • Internal links (classes, methods, parameters) for easier navigation of the docs.
  • Indentation changes (that looked wrong in the html or broke layout)
  • Standardization of certain formatting, like notes, syntax highlighting etc.

Sorry for so many lines changed :(
Let me know if it's too much or if you think some changes are not needed/wanted :)

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli changed the title Improve docs for LightingModule Improved docs for LightingModule Apr 6, 2020
@awaelchli awaelchli changed the title Improved docs for LightingModule Improved docs for LightningModule Apr 6, 2020
@mergify mergify bot requested a review from a team April 6, 2020 06:22
@codecov
Copy link

codecov bot commented Apr 6, 2020

Codecov Report

Merging #1389 into master will not change coverage by %.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #1389   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          63      63           
  Lines        3323    3323           
======================================
  Hits         3051    3051           
  Misses        272     272           

@awaelchli awaelchli marked this pull request as ready for review April 6, 2020 06:42
@Borda Borda added the docs Documentation related label Apr 6, 2020
@williamFalcon williamFalcon merged commit 26cb5f6 into Lightning-AI:master Apr 6, 2020
@awaelchli awaelchli deleted the docs/improve_lightning.py branch April 6, 2020 12:26
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
* improve docs for LightingModule

* fix typos

* revert a doctest

* more fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants