Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix silent TPU CI failures #14034

Merged
merged 11 commits into from
Aug 24, 2022
Merged

Fix silent TPU CI failures #14034

merged 11 commits into from
Aug 24, 2022

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Aug 5, 2022

What does this PR do?

Fixes #14039.

Something prevents test failures to trigger a failed CI.
Observed on master

#14013 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @carmocca @akihironitta @Borda @kaushikb11 @rohitgr7

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 22, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Aug 24, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 24, 2022
@awaelchli awaelchli marked this pull request as ready for review August 24, 2022 11:10
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Aug 24, 2022
@awaelchli awaelchli added ci Continuous Integration tests accelerator: tpu Tensor Processing Unit bug Something isn't working and removed tests labels Aug 24, 2022
@awaelchli awaelchli added this to the pl:1.7.x milestone Aug 24, 2022
@awaelchli awaelchli changed the title Debug silent TPU CI failures Fix silent TPU CI failures Aug 24, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 24, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@awaelchli awaelchli enabled auto-merge (squash) August 24, 2022 12:53
@awaelchli awaelchli merged commit 34f9883 into master Aug 24, 2022
@awaelchli awaelchli deleted the debug/tpu-fail branch August 24, 2022 13:24
carmocca added a commit that referenced this pull request Aug 25, 2022
awaelchli added a commit that referenced this pull request Aug 25, 2022

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
rohitgr7 pushed a commit that referenced this pull request Aug 25, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Aug 25, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accelerator: tpu Tensor Processing Unit bug Something isn't working ci Continuous Integration ready PRs ready to be merged
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TPU tests fail silently in CI
4 participants