-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix silent TPU CI failures #14034
Merged
Merged
Fix silent TPU CI failures #14034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
carmocca
reviewed
Aug 22, 2022
awaelchli
requested review from
Borda,
akihironitta and
tchaton
as code owners
August 24, 2022 11:10
awaelchli
added
ci
Continuous Integration
tests
accelerator: tpu
Tensor Processing Unit
bug
Something isn't working
and removed
tests
labels
Aug 24, 2022
carmocca
approved these changes
Aug 24, 2022
kaushikb11
approved these changes
Aug 24, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
rohitgr7
approved these changes
Aug 24, 2022
awaelchli
added a commit
that referenced
this pull request
Aug 25, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
rohitgr7
pushed a commit
that referenced
this pull request
Aug 25, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule
pushed a commit
that referenced
this pull request
Aug 25, 2022
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accelerator: tpu
Tensor Processing Unit
bug
Something isn't working
ci
Continuous Integration
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #14039.
Something prevents test failures to trigger a failed CI.
Observed on master
#14013 (comment)
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
cc @carmocca @akihironitta @Borda @kaushikb11 @rohitgr7