Weekly patch release v1.7.2 #14126

awaelchli · 2022-08-09T22:36:06Z

Patch Release v1.7.2

Commit list (pl:1.7.x and all:next)

gh pr list -s merged -S 'merged:2022-08-09T10:30:00.000Z..2022-08-16T12:00:00.000Z' --json mergedAt,milestone,url,mergeCommit,title --jq 'sort_by(.mergedAt) | reverse | .[] | select((.milestone.title == "pl:1.7.x") or (.milestone.title == null) or (.milestone.title == "all:next")) | [.url, .mergeCommit.oid, .title] | join(" ")' --limit 100

Author list (pl:1.7.x and all:next):

gh pr list -s merged -S 'merged:2022-08-09T20:30:00.000Z..2022-08-16T22:00:00.000Z' --json author,milestone --jq '.[] | select((.milestone.title == "pl:1.7.x") or (.milestone.title == null) or (.milestone.title == "all:next")) | ["@" + .author.login] | join("")' --limit 100 | sort --ignore-case | uniq | xargs echo

https://github.com/Lightning-AI/lightning/pull/14212 44cdbcab04e0453cfea46cf3b16fda600ceda50e Allowed setting attributes on `DataLoader` and `BatchSampler` when instantiated inside `*_dataloader` hooks
https://github.com/Lightning-AI/lightning/pull/14246 909e7e77880deb825dbe92c00012a1bba33ba80c CI: docker focus on PL only
https://github.com/Lightning-AI/lightning/pull/14216 acd4805f1a284e513272d150de6f98f27a0489b3 CI: clean building docs
https://github.com/Lightning-AI/lightning/pull/14174 2622989b108368813fdd3850b002fd1ad69988c2 add more issues types
https://github.com/Lightning-AI/lightning/pull/14092 48c23e571637438726662104325c05ba768288be Use fsdp module to initialize precision scalar for fsdp native
https://github.com/Lightning-AI/lightning/pull/14170 fe9e5d55bf7991ba36b76d6adae9075b93dfcaa0 Remove skipping logic in favor of path filtering
https://github.com/Lightning-AI/lightning/pull/14097 c8e22b4572277dec395eb5cd7ce6c3451e410847 Avoid raising the sampler warning if num_replicas=1
https://github.com/Lightning-AI/lightning/pull/14143 6789a066b52ebbcc94048cac72c0de9b350e74e5 Avoid false positive warning about using `sync_dist` when using torchmetrics
https://github.com/Lightning-AI/lightning/pull/14069 2d9e00fab64c8b19a8646f755a95bcb092aa710f Profile batch transfer and gradient clipping hooks
https://github.com/Lightning-AI/lightning/pull/14165 d0f82abe35c271247d58da35442719e01a54604c Configure the check-group app
https://github.com/Lightning-AI/lightning/pull/13967 56533368afe14407867dc999a65b799d0f4bd89b Remove DeepSpeed version restriction from Lite
https://github.com/Lightning-AI/lightning/pull/14151 3b18da3eafa8ece27cde46ad978f765a1390d72d Fix saving hyperparameters in a composition where parent is not a LM or LDM
https://github.com/Lightning-AI/lightning/pull/14157 3dc08b1ef565774853467a7e56842becfa381dd6 Fix flaky test caused by weak reference
https://github.com/Lightning-AI/lightning/pull/14154 a7cebf24169dbe80c5e718946cb5de931082f814 Fix entry point test for Python 3.10
https://github.com/Lightning-AI/lightning/pull/14101 4008f9cd414db2b0319b62ab4cb5d2193c6e97ed Convert subprocess test to standalone test
https://github.com/Lightning-AI/lightning/pull/14083 7e7736778bfc1f3864d878458b9de87de7ded52c Update onnxruntime requirement from <=1.12.0 to <1.13.0 in /requirements
https://github.com/Lightning-AI/lightning/pull/14079 f11f1e2bb470a57f4043a41b1cdf194071c4be1e Update gcsfs requirement from <2022.6.0,>=2021.5.0 to >=2021.5.0,<2022.8.0 in /requirements
https://github.com/Lightning-AI/lightning/pull/14117 f132d44821f9fe7ad83d74edbb13dc6ee7769a3d Fix a bug that caused spurious `AttributeError` when multiple `DataLoader` classes are imported
https://github.com/Lightning-AI/lightning/pull/14052 4e87a44002a91c869f43c0929d29fa8600f14f15 Avoid entry_points deprecation warning
https://github.com/Lightning-AI/lightning/pull/13831 d5f35ece72fd253adeb8e9947fd9be4a5992f8f8 CI/CD: Add CUDA version to docker image tags
https://github.com/Lightning-AI/lightning/pull/14128 dc8ff5ed2699b2ab9d21ee1ea6270191e290f620 Fix device placement when `.cuda()` called without specifying index
https://github.com/Lightning-AI/lightning/pull/14129 dfda3f384e020ab3955a2cf3fe29dcd831d8a969 CI: Update Windows version from 2019 to 2022
https://github.com/Lightning-AI/lightning/pull/13917 d211d46e1db3ca4c4c938cafbfe51704f51b8ab4 CI: Replace `_` of in GHA workflow filenames with `-`
https://github.com/Lightning-AI/lightning/pull/9938 975a4fc2f1daf5a1662a0d1f47212e7dcdae8b2b Support checkpoint save and load with Stochastic Weight Averaging
https://github.com/Lightning-AI/lightning/pull/14121 06c255c5c1889e6ecc640dc82a24193ce388511a Fix DDP-fork test that can only run on fork supported OS
https://github.com/Lightning-AI/lightning/pull/14115 be581598ef74d8877361616c0eb83bfbf1d8e34d Weekly patch release v1.7.1
https://github.com/Lightning-AI/lightning/pull/14061 d85085479d9248d2f6a06821a0cb41c4a2eb02fc Reset all results on epoch end
https://github.com/Lightning-AI/lightning/pull/14112 56abd60f048f43a7abd036380a6b5297baaa3854 Fix assert wandb Run when mode="disabled"
https://github.com/Lightning-AI/lightning/pull/14041 ac369f5570d0a492d08ac9c2ba6622e451d7e131 Fix incorrect `precision="mixed"` being used with `DeepSpeedStrategy` and `IPUStrategy`

Note: Last passing tests on fcf9c5c

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @Borda

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

…14128)

…or LDM (#14151) Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Jirka <jirka.borovec@seznam.cz>

…nts (#14083) Updates the requirements on [onnxruntime](https://github.com/microsoft/onnxruntime) to permit the latest version. - [Release notes](https://github.com/microsoft/onnxruntime/releases) - [Changelog](https://github.com/microsoft/onnxruntime/blob/master/docs/ReleaseManagement.md) - [Commits](microsoft/onnxruntime@v0.1.4...v1.12.1) --- updated-dependencies: - dependency-name: onnxruntime dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…2.8.0 in /requirements (#14079) Update gcsfs requirement in /requirements Updates the requirements on [gcsfs](https://github.com/fsspec/gcsfs) to permit the latest version. - [Release notes](https://github.com/fsspec/gcsfs/releases) - [Commits](fsspec/gcsfs@2021.05.0...2022.7.1) --- updated-dependencies: - dependency-name: gcsfs dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…ader` classes are imported (#14117) fix

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

Co-authored-by: Jirka <jirka.borovec@seznam.cz>

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

…metrics (#14143) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>

) Co-authored-by: thomas chaton <thomas@grid.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Carlos Mocholi <carlossmocholi@gmail.com> Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

awaelchli · 2022-08-16T09:36:15Z

We should include #14145 IMO.

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Laverne Henderson <laverne.henderson@coupa.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

* add more issues types * Update .github/ISSUE_TEMPLATE/config.yml Co-authored-by: Mansy <ahmed.mansy156@gmail.com> * typo Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com> Co-authored-by: Mansy <ahmed.mansy156@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Laverne Henderson <laverne.henderson@coupa.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

* CI: clean building docs * group * .

* CI: docker focus on PL only * group

…stantiated inside `*_dataloader` hooks (#14212) Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>

…14244)

codecov · 2022-08-17T19:00:36Z

Codecov Report

Merging #14126 (a3f48c1) into release/pytorch (be58159) will increase coverage by 6%.
The diff coverage is 89%.

@@                 Coverage Diff                 @@
##           release/pytorch   #14126      +/-   ##
===================================================
+ Coverage               80%      86%      +6%     
===================================================
  Files                  103      342     +239     
  Lines                 6803    26695   +19892     
===================================================
+ Hits                  5418    22839   +17421     
- Misses                1385     3856    +2471

awaelchli and others added 2 commits August 10, 2022 00:31

update version and changelog for 1.7.2 release

695a01e

Reset all results on epoch end (#14061)

f7a189f

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

awaelchli requested review from williamFalcon, Borda, carmocca, tchaton, justusschock, kaushikb11, akihironitta and rohitgr7 as code owners August 9, 2022 22:36

mergify bot added the has conflicts label Aug 9, 2022

awaelchli added release and removed has conflicts labels Aug 9, 2022

awaelchli added this to the pl:1.7.x milestone Aug 9, 2022

awaelchli changed the base branch from master to release/pytorch August 9, 2022 22:36

awaelchli self-assigned this Aug 9, 2022

awaelchli marked this pull request as draft August 9, 2022 22:36

Skip ddp fork tests on windows (#14121)

afe40c0

github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 9, 2022

awaelchli and others added 10 commits August 10, 2022 11:24

Fix device placement when .cuda() called without specifying index (#…

c76c381

…14128)

Convert subprocess test to standalone test (#14101)

e385ea4

Fix entry point test for Python 3.10 (#14154)

1b320a5

Fix flaky test caused by weak reference (#14157)

552f496

Fix saving hyperparameters in a composition where parent is not a LM …

a59ee10

…or LDM (#14151) Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Remove DeepSpeed version restriction from Lite (#13967)

9ffbe07

Configure the check-group app (#14165)

c6f2c36

Co-authored-by: Jirka <jirka.borovec@seznam.cz>

Fix a bug that caused spurious AttributeError when multiple `DataLo…

fcf9c5c

…ader` classes are imported (#14117) fix

awaelchli force-pushed the bugfix/draft-1.7.2 branch from 4b8526a to fcf9c5c Compare August 15, 2022 16:51

awaelchli and others added 7 commits August 15, 2022 18:59

Avoid entry_points deprecation warning (#14052)

4f5e101

Co-authored-by: Adam J. Stewart <ajstewart426@gmail.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

Configure the check-group app (#14165)

af9841c

Co-authored-by: Jirka <jirka.borovec@seznam.cz>

Profile batch transfer and gradient clipping hooks (#14069)

f3f282b

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Avoid false positive warning about using sync_dist when using torch…

3dd0faf

…metrics (#14143) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Avoid raising the sampler warning if num_replicas=1 (#14097)

6a78b2a

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>

Remove skipping logic in favor of path filtering (#14170)

c9aa3e5

awaelchli marked this pull request as ready for review August 16, 2022 09:34

awaelchli requested a review from edenlightning as a code owner August 16, 2022 09:34

rohitgr7 approved these changes Aug 16, 2022

View reviewed changes

Borda approved these changes Aug 16, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Aug 16, 2022

justusschock approved these changes Aug 16, 2022

View reviewed changes

awaelchli and others added 4 commits August 17, 2022 18:08

Use fsdp module to initialize precision scalar for fsdp native (#14092)

9f189ff

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Laverne Henderson <laverne.henderson@coupa.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

CI: clean building docs (#14216)

9237eda

* CI: clean building docs * group * .

CI: docker focus on PL only (#14246)

20984f5

* CI: docker focus on PL only * group

awaelchli requested a review from Felonious-Spellfire as a code owner August 17, 2022 16:11

github-actions bot removed the pl Generic label for PyTorch Lightning package label Aug 17, 2022

Allowed setting attributes on DataLoader and BatchSampler when in…

b4250e5

…stantiated inside `*_dataloader` hooks (#14212) Co-authored-by: otaj <6065855+otaj@users.noreply.github.com>

awaelchli force-pushed the bugfix/draft-1.7.2 branch from 1fa28ba to b4250e5 Compare August 17, 2022 16:13

Revert "Remove skipping logic in favor of path filtering (#14170)" (#…

1a65a9a

…14244)

awaelchli force-pushed the bugfix/draft-1.7.2 branch from 28ad5f8 to 21f5844 Compare August 17, 2022 16:33

Update defaults for WandbLogger's run name and project name (#14145)

a3f48c1

awaelchli force-pushed the bugfix/draft-1.7.2 branch from 21f5844 to a3f48c1 Compare August 17, 2022 16:34

lexierule merged commit 4fae327 into release/pytorch Aug 17, 2022

lexierule deleted the bugfix/draft-1.7.2 branch August 17, 2022 20:16

awaelchli removed this from the pl:1.7.x milestone Aug 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly patch release v1.7.2 #14126

Weekly patch release v1.7.2 #14126

awaelchli commented Aug 9, 2022 •

edited

Loading

awaelchli commented Aug 16, 2022

codecov bot commented Aug 17, 2022

Weekly patch release v1.7.2 #14126

Weekly patch release v1.7.2 #14126

Conversation

awaelchli commented Aug 9, 2022 • edited Loading

Before submitting

PR review

Did you have fun?

awaelchli commented Aug 16, 2022

codecov bot commented Aug 17, 2022

Codecov Report

awaelchli commented Aug 9, 2022 •

edited

Loading