Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] uneven input support for DDP #14284

Closed
wants to merge 4 commits into from
Closed

[WIP] uneven input support for DDP #14284

wants to merge 4 commits into from

Conversation

otaj
Copy link
Contributor

@otaj otaj commented Aug 18, 2022

What does this PR do?

WIP for Uneven input support for DDP

Fixes #3325

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Aug 18, 2022
@otaj otaj changed the title [WIP] uneven input support [WIP] uneven input support for DDP Aug 18, 2022
@@ -362,7 +367,9 @@ def reduce(
def training_step(self, *args: Any, **kwargs: Any) -> STEP_OUTPUT:
assert self.model is not None
with self.precision_plugin.train_step_context():
return self.model(*args, **kwargs)
with DistCallRecorder() as recorder:
with Join([self.model], enable=True, dist_recorder=recorder):
Copy link
Contributor

@carmocca carmocca Sep 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be opt-in (Maybe you set enable=True by default whilst it's WIP)

@stale
Copy link

stale bot commented Oct 15, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Oct 15, 2022
@anth2o
Copy link

anth2o commented Oct 21, 2022

Hello !
Is this PR still ongoing ?

@stale stale bot removed the won't fix This will not be worked on label Oct 21, 2022
@otaj
Copy link
Contributor Author

otaj commented Oct 21, 2022

Hello ! Is this PR still ongoing ?

Hi @anth2o! Currently, there is no progress. It is somewhat still on my radar, but I've been busy with higher priority items lately.

We still want to finalize it, but it doesn't have the highest priority, honestly, so there is no ETA.

@anth2o
Copy link

anth2o commented Oct 21, 2022

Thanks for your answer, I'll try to find a solution on my end to handle this

@carmocca carmocca closed this Nov 7, 2022
@carmocca carmocca deleted the feat/ddp_uneven_input branch November 7, 2022 18:25
@ssharpe42
Copy link

Is there anything on this topic being worked on currently? What is the current best suggestion in the case of using iterable datasets on separate (possibly unequal) sharded data for each gpu in training and evaluation w/ torchmetrics?

@ssharpe42
Copy link

Forgot to tag @carmocca @otaj. Also @anth2o did you find a solution here?

@ivandariojr
Copy link

This would be really useful to get consistent evaluations of datasets that may not be divisible by the number of devices. Has there been any progress on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support uneven DDP inputs with pytorch model.join
5 participants