-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] uneven input support for DDP #14284
Conversation
@@ -362,7 +367,9 @@ def reduce( | |||
def training_step(self, *args: Any, **kwargs: Any) -> STEP_OUTPUT: | |||
assert self.model is not None | |||
with self.precision_plugin.train_step_context(): | |||
return self.model(*args, **kwargs) | |||
with DistCallRecorder() as recorder: | |||
with Join([self.model], enable=True, dist_recorder=recorder): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be opt-in (Maybe you set enable=True
by default whilst it's WIP)
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
Hello ! |
Hi @anth2o! Currently, there is no progress. It is somewhat still on my radar, but I've been busy with higher priority items lately. We still want to finalize it, but it doesn't have the highest priority, honestly, so there is no ETA. |
Thanks for your answer, I'll try to find a solution on my end to handle this |
Is there anything on this topic being worked on currently? What is the current best suggestion in the case of using iterable datasets on separate (possibly unequal) sharded data for each gpu in training and evaluation w/ torchmetrics? |
This would be really useful to get consistent evaluations of datasets that may not be divisible by the number of devices. Has there been any progress on this? |
What does this PR do?
WIP for Uneven input support for DDP
Fixes #3325
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃