Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: set probot timeout #14455

Merged
merged 1 commit into from
Aug 30, 2022
Merged

CI: set probot timeout #14455

merged 1 commit into from
Aug 30, 2022

Conversation

Borda
Copy link
Member

@Borda Borda commented Aug 30, 2022

What does this PR do?

Seems we have some problem with probot as the CI is running for ever

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @tchaton @rohitgr7 @carmocca @akihironitta @Borda

@Borda Borda added priority: 0 High priority task ci Continuous Integration labels Aug 30, 2022
@Borda Borda added this to the pl:future milestone Aug 30, 2022
@lexierule lexierule merged commit 36aefda into master Aug 30, 2022
@lexierule lexierule deleted the ci/probot-to branch August 30, 2022 17:03
@@ -9,6 +9,7 @@ jobs:
required-jobs:
runs-on: ubuntu-latest
if: github.event_name != 'issue_comment' || contains(github.event.comment.body, '@probot pls')
timeout-minutes: 5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting the timeout here won't change anything, will it? (not sure but I guess because it doesn't account for queueing time.)

There are tons of jobs waiting in the queue, and they all are triggered by check_run.
https://github.com/Lightning-AI/lightning/actions?query=event%3Acheck_run+is%3Aqueued

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just saw #14456! :)

Copy link
Member Author

@Borda Borda Aug 30, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, this does not change anything with running or queued...
But will prevent it for future work... 🐰

@Borda Borda self-assigned this Aug 30, 2022
@carmocca carmocca modified the milestones: pl:future, pl:1.8 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration priority: 0 High priority task
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants