Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace automatic nan check with optional flag #1475

Merged

Conversation

ethanwharris
Copy link
Member

@ethanwharris ethanwharris commented Apr 13, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1392

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 13, 2020 17:40
@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #1475 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1475   +/-   ##
======================================
  Coverage      91%     91%           
======================================
  Files          67      67           
  Lines        3742    3745    +3     
======================================
+ Hits         3400    3403    +3     
  Misses        342     342           

@williamFalcon williamFalcon merged commit 8544b33 into Lightning-AI:master Apr 13, 2020
@ethanwharris ethanwharris deleted the feature/optional_nan_check branch April 13, 2020 18:07
@Borda Borda added the feature Is an improvement or enhancement label Apr 13, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 13, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
* Replace automatic nan check with optional flag

* Update CHANGELOG.md
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Is an improvement or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to disable Trainer.detect_nan_tensors
3 participants