Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why copy? #1579

Merged
merged 1 commit into from
Apr 23, 2020
Merged

why copy? #1579

merged 1 commit into from
Apr 23, 2020

Conversation

williamFalcon
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 23, 2020 18:32
@williamFalcon
Copy link
Contributor Author

@tgaddair i can't remember why need a copy here... i assume you just grabbed it from what we were doing?

@tgaddair
Copy link
Contributor

@tgaddair i can't remember why need a copy here... i assume you just grabbed it from what we were doing?

Yes, no particular reason other than to match style. Thanks for checking.

@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@41b6cbb). Click here to learn what that means.
The diff coverage is 0%.

@@           Coverage Diff            @@
##             master   #1579   +/-   ##
========================================
  Coverage          ?     89%           
========================================
  Files             ?      68           
  Lines             ?    3913           
  Branches          ?       0           
========================================
  Hits              ?    3473           
  Misses            ?     440           
  Partials          ?       0           

@williamFalcon williamFalcon merged commit 68ca577 into master Apr 23, 2020
@Borda Borda deleted the copy branch April 23, 2020 20:43
@Borda Borda added the bug Something isn't working label Apr 23, 2020
@Borda Borda added this to the 0.7.4 milestone Apr 23, 2020
@Borda Borda modified the milestones: 0.7.4, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants