Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow metrics logged together with hparams #1630

Merged
merged 6 commits into from
Apr 27, 2020
Merged

Allow metrics logged together with hparams #1630

merged 6 commits into from
Apr 27, 2020

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Apr 27, 2020 •
edited
Loading

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1228 .

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@justusschock justusschock requested review from williamFalcon, Borda and a team April 27, 2020 07:45
@justusschock justusschock self-assigned this Apr 27, 2020
@pep8speaks
Copy link

pep8speaks commented Apr 27, 2020 •
edited
Loading

Hello @justusschock! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-04-27 07:54:08 UTC

@codecov
Copy link

codecov bot commented Apr 27, 2020

Codecov Report

Merging #1630 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1630   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files          71      71           
  Lines        4164    4166    +2     
======================================
+ Hits         3689    3691    +2     
  Misses        475     475

@williamFalcon williamFalcon merged commit 8b82ce0 into master Apr 27, 2020
@awaelchli
Copy link
Contributor

@justusschock awesome!

@Borda Borda deleted the hparams_logger branch April 27, 2020 11:56
@Borda Borda added the feature Is an improvement or enhancement label Apr 27, 2020
@Borda Borda added this to the 0.7.5 milestone Apr 27, 2020
@Borda Borda restored the hparams_logger branch April 27, 2020 13:28
Borda pushed a commit that referenced this pull request Apr 27, 2020
@justusschock @Borda
Allow metrics logged together with hparams (#1630)
b83b800 
Update tensorboard.py

Update CHANGELOG.md

Update tensorboard.py

Update test_tensorboard.py

Update test_tensorboard.py

tests pep8
@Borda Borda deleted the hparams_logger branch April 27, 2020 15:25
@Borda Borda modified the milestones: 0.7.6, 0.7.5 Apr 27, 2020
@justusschock justusschock mentioned this pull request Apr 28, 2020
Merged
5 tasks
@awaelchli awaelchli mentioned this pull request May 3, 2020
Closed
@justusschock justusschock mentioned this pull request May 12, 2020
Closed
@Borda Borda modified the milestones: 0.7.5, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@justusschock justusschock

Labels
feature Is an improvement or enhancement
Projects
None yet
Milestone
pl:0.7.x
Development

Successfully merging this pull request may close these issues.

Add support to log hparams and metrics to tensorboard?
5 participants
@justusschock @pep8speaks @awaelchli @williamFalcon @Borda