Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary copy saving checkpoint to fsspec files #17590

Closed
wants to merge 4 commits into from
Closed

Avoid unnecessary copy saving checkpoint to fsspec files #17590

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
07e1ded
Avoid unnecessary copy saving checkpoint to fsspec files
byronyi May 8, 2023
9e96b4e
Merge branch 'master' into patch-1
Borda May 9, 2023
74510a3
Merge branch 'master' into patch-1
byronyi May 11, 2023
10b0ad1
Merge branch 'master' into patch-1
Borda May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/lightning/fabric/utilities/cloud_io.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# limitations under the License.
"""Utilities related to data saving/loading."""

import io
from pathlib import Path
from typing import Any, Dict, IO, Union

Expand Down Expand Up @@ -66,7 +65,5 @@ def _atomic_save(checkpoint: Dict[str, Any], filepath: Union[str, Path]) -> None
filepath: The path to which the checkpoint will be saved.
This points to the file that the checkpoint will be stored in.
"""
bytesbuffer = io.BytesIO()
carmocca marked this conversation as resolved.
Show resolved Hide resolved
torch.save(checkpoint, bytesbuffer)
with fsspec.open(filepath, "wb") as f:
f.write(bytesbuffer.getvalue())
torch.save(checkpoint, f)