Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing docs #1821

Merged
merged 10 commits into from
May 14, 2020
Merged

Fix failing docs #1821

merged 10 commits into from
May 14, 2020

Conversation

Borda
Copy link
Member

@Borda Borda commented May 13, 2020

What does this PR do?

Add missing yaml pkg in mock and update CI workflow

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added docs Documentation related priority: 0 High priority task labels May 13, 2020
@Borda Borda requested a review from awaelchli May 13, 2020 21:55
@mergify mergify bot requested a review from a team May 13, 2020 21:56
docs/Makefile Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team May 13, 2020 22:06
@Borda Borda added this to the 0.7.6 milestone May 13, 2020
@Borda Borda marked this pull request as ready for review May 13, 2020 22:58
.circleci/config.yml Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team May 13, 2020 23:31
docs/source/conf.py Outdated Show resolved Hide resolved
@mergify mergify bot requested a review from a team May 14, 2020 01:18
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mergify mergify bot requested a review from a team May 14, 2020 08:44
@williamFalcon williamFalcon merged commit 1c10560 into master May 14, 2020
@Borda Borda deleted the docs/yaml branch May 28, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related priority: 0 High priority task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants