Support OmegaConf in Lightning

[Darktex]

Lightning hparams were recently changed to support only dicts and ArgParse namespaces. This diff (re)introduces compatibility with OmegaConf DictConfig, which is the type of config that Hydra uses.

What does this PR do?

Fixes #1880.

[pep8speaks]

Hello @Darktex! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-05-22 15:00:06 UTC

[tullie]

lgtm just fix the formatting comment

[yukw777]

How does this PR play with this discussion: #1871?

[williamFalcon]

let’s add support for this now while we work out a good long-term solution. Thanks for the PR!

[Borda]

need to add loading from DictConfig

[tullie]

@Borda Can you explain your comment a bit more? I don't understand the issue

[Borda]

@Borda Can you explain your comment a bit more? I don't understand the issue

https://github.com/PyTorchLightning/pytorch-lightning/blob/9b629637b890a1eb9a0d9011bfa10322e0d89da0/pytorch_lightning/core/lightning.py#L1613-L1617

[ImMrMa]

@Borda Can you explain your comment a bit more? I don't understand the issue

https://github.com/PyTorchLightning/pytorch-lightning/blob/9b629637b890a1eb9a0d9011bfa10322e0d89da0/pytorch_lightning/core/lightning.py#L1613-L1617

save the DictConfig to hparms.yaml and load it need to do!

[mergify]

This pull request is now in conflict... :(

[Darktex]

I'm editing this from the WebUI so the experience is... uh... improvable? :D But hopefully this should do the trick

[Darktex]

I could add a test for this here https://github.com/PyTorchLightning/pytorch-lightning/blob/master/tests/trainer/test_trainer.py#L29

but it would require to add omegaconf as a dep. What do you guys think?

[codecov]

Codecov Report

Merging #1883 into master will increase coverage by 0%.
The diff coverage is 52%.

@@          Coverage Diff           @@
##           master   #1883   +/-   ##
======================================
  Coverage      88%     88%           
======================================
  Files          74      74           
  Lines        4603    4608    +5     
======================================
+ Hits         4062    4069    +7     
+ Misses        541     539    -2     

[williamFalcon]

we can add as a test dep but let’s keep it out of the main requirements. we already do this with the loggers as well

[mergify]

This pull request is now in conflict... :(

[Borda]

@Darktex how is it going, mind finish it? it seems that Will was asking for some tests...

[Darktex]

Looks like we don't need this anymore after #1896 landed

[williamFalcon]

@Darktex i assume this means omegaconf is now supported after we generalized the init?

[williamFalcon]

Fixed in #2025.
Reworked with new hparams.
@Borda is working on supporting the DictConfig for saving in hparams