Fix root node resolution for SLURM cluster with dash in host name

[LoicGrobol]

Before submitting

• Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
• Did you read the contributor guideline, Pull Request section?
• Did you make sure to update the docs?
  • No need for a bugfix, right?
• Did you write any new necessary tests?
  • Not sure if this need any new tests as the general behaviour of the function is already tested
• If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes #1943

For now this is about the minimal change to fix the issue, but it might be better to completely rewrite the function as

def resolve_root_node_address(root_node):
    """Extract a root node from a SLURM node list."""
    m = re.match(r"(?P<name>.*?)\[(?P<number>\d+)(-\d+)?(,.*)?\]", root_node)
    if not m:
        return root_node
    if m.group("number") is None:
        return m.group("name")
    return m.group("name") + m.group("number")

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

[williamFalcon]

Don't we have tests for this? Mind adding a test just to make sure we don't break the other cases?

[LoicGrobol]

@williamFalcon Well it's already tested (but weirdly enough, it's in the amp tests so maybe it would be worth it to move these elsewhere) for a basic case (abc[23-24, 45-40, 40] and some variants). I don't mind adding test cases with a dash or other quirks but I am not sure it is really interesting so you tell me :-)

[williamFalcon]

@LoicGrobol great! Good contribution :)

[LoicGrobol]

@williamFalcon Haha, just scratching my itch, thanks for merging :-)