-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increase acc #2039
increase acc #2039
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2039 +/- ##
======================================
Coverage 86% 86%
======================================
Files 74 74
Lines 4710 4710
======================================
Hits 4066 4066
Misses 644 644 |
seems we have a hanging test for macOS and py3.8 |
@SkafteNicki this test is causing problem on macOS and py3.8 |
@Borda not completly sure why it is failing specific on mac. Do you know how much RAM the machines have the test are running on? Since the test currently are evaluated on cpu, it is only when the RAM is filled up we get an OOM error and the search stops. Maybe it would help switching these tests to gpu, since the memory is smaller the test will be faster? |
@SkafteNicki it is running on the very same servers, just different images... |
@Borda am I reading the checks correct, that it works on mac with python 3.7 but not with python 3.8? |
exactly... :] |
This solves the issue with invalid accuracy tests... |
What does this PR do?
Fixes #2029. See #2029 (comment)
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃