Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misleading exception raised during batch scaling #2223

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Misleading exception raised during batch scaling #2223

merged 3 commits into from
Jul 29, 2020

Commits on Jul 1, 2020

  1. Misleading exception raised during batch scaling 

    Use batch_size from `model.hparams.batch_size` instead of `model.batch_size`
    @tejasvi @Borda
    tejasvi authored and Borda committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    4378257 View commit details
    Browse the repository at this point in the history

  2. Improvements considering #1896

    @tejasvi @Borda
    tejasvi authored and Borda committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    179f6a5 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
    @tejasvi @Borda
    tejasvi and Borda committed Jul 1, 2020
    Configuration menu
    Copy the full SHA
    3d79243 View commit details
    Browse the repository at this point in the history