Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sum(0) for trainer.num_val_batches #2268

Merged
merged 1 commit into from
Jun 19, 2020

Conversation

pwl
Copy link
Contributor

@pwl pwl commented Jun 19, 2020

What does this PR do?

Fixes a minor bug introduced in #2213 (see the comment).

@mergify mergify bot requested a review from a team June 19, 2020 11:35
@Borda Borda added the bug Something isn't working label Jun 19, 2020
@mergify mergify bot requested a review from a team June 19, 2020 11:59
@Borda Borda changed the title Update progress.py fix sum(0) for trainer.num_val_batches Jun 19, 2020
@Borda Borda added this to the 0.8.x milestone Jun 19, 2020
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #2268 into master will decrease coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2268   +/-   ##
======================================
- Coverage      88%     88%   -0%     
======================================
  Files          70      70           
  Lines        5486    5485    -1     
======================================
- Hits         4814    4813    -1     
  Misses        672     672           

Fixes a minor bug introduced in Lightning-AI#2213
@Borda Borda added the ready PRs ready to be merged label Jun 19, 2020
@mergify mergify bot requested a review from a team June 19, 2020 19:15
@williamFalcon williamFalcon merged commit 3256fe4 into Lightning-AI:master Jun 19, 2020
@pwl pwl deleted the patch-1 branch June 20, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants