Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an import deprecation warning #2746

Merged
merged 1 commit into from
Jul 29, 2020

Conversation

bryant1410
Copy link
Contributor

What does this PR do?

Fix an import deprecation warning (collections -> collections.abc for some classes).

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team July 29, 2020 04:38
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #2746 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #2746   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          82      82           
  Lines        6791    6791           
======================================
  Hits         6131    6131           
  Misses        660     660           

@Borda Borda added bug Something isn't working ci Continuous Integration labels Jul 29, 2020
@Borda Borda added the ready PRs ready to be merged label Jul 29, 2020
@mergify mergify bot requested a review from a team July 29, 2020 07:07
@williamFalcon williamFalcon merged commit 1767822 into Lightning-AI:master Jul 29, 2020
@bryant1410 bryant1410 mentioned this pull request Aug 2, 2020
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants