-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use kubectl to get logs from TPU CI instead of gcloud logging. #2918
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2918 +/- ##
======================================
Coverage 90% 90%
======================================
Files 80 80
Lines 7422 7422
======================================
Hits 6706 6706
Misses 716 716 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can ve do the same also for GH actions?
Made the same change to the Github Action. The CircleCI job looks good in e2e run but I think we can't test the Github Action until PR is submitted |
…ning-AI#2918) * Use kubectl to get logs from TPU CI instead of gcloud logging. * Update Github Action to read logs from kubectl rather than gcloud logging.
What does this PR do?
Use
kubectl logs
to retrieve logs instead ofgcloud logging read
in the TPU CI setup. This should reduce e2e testing time by ~1-3 minutes.Fixes # (issue)
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃