Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kubectl to get logs from TPU CI instead of gcloud logging. #2918

Merged
merged 2 commits into from
Aug 11, 2020
Merged

Use kubectl to get logs from TPU CI instead of gcloud logging. #2918

merged 2 commits into from
Aug 11, 2020

Conversation

zcain117
Copy link
Contributor

@zcain117 zcain117 commented Aug 11, 2020

What does this PR do?

Use kubectl logs to retrieve logs instead of gcloud logging read in the TPU CI setup. This should reduce e2e testing time by ~1-3 minutes.

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team August 11, 2020 20:11
@Borda Borda added the ci Continuous Integration label Aug 11, 2020
@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #2918 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2918   +/-   ##
======================================
  Coverage      90%     90%           
======================================
  Files          80      80           
  Lines        7422    7422           
======================================
  Hits         6706    6706           
  Misses        716     716           

Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can ve do the same also for GH actions?

@mergify mergify bot requested a review from a team August 11, 2020 20:22
@zcain117
Copy link
Contributor Author

can ve do the same also for GH actions?

Made the same change to the Github Action. The CircleCI job looks good in e2e run but I think we can't test the Github Action until PR is submitted

@mergify mergify bot requested a review from a team August 11, 2020 20:48
@Borda Borda requested review from ethanwharris, jeremyjordan, justusschock, nateraw and rohitgr7 and removed request for a team August 11, 2020 20:48
@mergify mergify bot requested a review from a team August 11, 2020 20:48
@mergify mergify bot requested a review from a team August 11, 2020 22:07
@Borda Borda added the ready PRs ready to be merged label Aug 11, 2020
@Borda Borda added this to the 0.9.0 milestone Aug 11, 2020
@williamFalcon williamFalcon merged commit 580a5bd into Lightning-AI:master Aug 11, 2020
ameliatqy pushed a commit to ameliatqy/pytorch-lightning that referenced this pull request Aug 17, 2020
…ning-AI#2918)

* Use kubectl to get logs from TPU CI instead of gcloud logging.

* Update Github Action to read logs from kubectl rather than gcloud logging.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants